[v0.8 replacement 1/5] add Prime Agent harness on current main - #2324
Open
sethkarten wants to merge 7 commits into
Open
[v0.8 replacement 1/5] add Prime Agent harness on current main#2324sethkarten wants to merge 7 commits into
sethkarten wants to merge 7 commits into
Conversation
sethkarten
marked this pull request as ready for review
August 12, 2026 06:18
ApprovabilityVerdict: Needs human review 1 blocking correctness issue found. This PR introduces a substantial new Prime Agent harness with ~700+ lines of new implementation code, modifications to core ACP infrastructure for error callbacks, and daemon lifecycle management. New feature additions of this scope warrant human review to verify the design and integration approach. You can customize Macroscope's approvability policy. Learn more. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dca0477. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Replacement stack
Node 1/5 in a fresh append-only v0.8 replacement chain rooted at authoritative
maincommitc2820d3679e6318f9c3d0155c823d6908b4e1faa.mainv080/main-replacement-prime-harnessf4a32c192fd9dabefe6938e36b6893bf86f9e49cScope
Exact coherent #2285 Prime Agent harness/test delta: 12 paths; no dependency or lockfile changes.
The old contributor PR branches remain untouched. This branch was published non-force from a fresh owned repository. Independent Luna semantic review APPROVED the full N1→N5 chain and found no structural scope leakage; authoritative-main renderer provenance is retained and
pyproject.toml/uv.lockare unchanged across replacement nodes.Warning
TEST BLOCKED — do not merge or mark ready. Authoritative
c2820dhas a staleuv.lockrelative topyproject.toml. A disposableuv sync --lockedcorrectly refused before tests, without changing repository files. The only previously approved interpreter also cannot import current main becausepydantic_configis absent. Testing/remediation continues on GitHub; this draft does not claim green.No live, hosted, Docker, sandbox, model, or paid evaluation was run.
Note
Add Prime Agent harness for running agents via ACP with persistent IPython kernel support
PrimeAgentHarnessin harness.py that installs and runs Prime Agent via ACP, supporting both one-shot and live-session modes with a persistent IPython kernel across turns.ACPHarnessSessiongains anon_errorcallback so harnesses can attach daemon log diagnostics to untyped errors while preserving typedRolloutErrorexceptions.Macroscope summarized 7e3bfc4.
Note
Medium Risk
Large new harness plus a shared ACP session error-path change; carefully preserves typed rollout errors, but install/runtime behavior and live-process semantics are infra-sensitive.
Overview
Adds a Prime Agent harness that runs the agent through native ACP with a persistent live session (one IPython kernel across turns), pinned install/setup, daemon diagnostics, and careful cleanup.
Extends shared
ACPHarnessSessionwith an optionalon_errorcallback so turn failures can attach daemon logs without replacing typedRolloutErrors (or masking cancellation).Adds
prime_agent-marked Docker e2e coverage for kernel persistence, verbatim IPython cell execution, GSM8K scoring, and provider-failure surfacing, plus deterministic unit guards for install/cleanup/error and unix socket path limits.Reviewed by Cursor Bugbot for commit 7e3bfc4. Bugbot is set up for automated code reviews on this repo. Configure here.