Skip to content

Run all ACP harnesses on persistent live sessions - #2291

Open
xeophon wants to merge 11 commits into
mainfrom
fix/hermes-acp-resume
Open

Run all ACP harnesses on persistent live sessions#2291
xeophon wants to merge 11 commits into
mainfrom
fix/hermes-acp-resume

Conversation

@xeophon

@xeophon xeophon commented Aug 7, 2026

Copy link
Copy Markdown
Member

Summary

This makes persistent LiveACP the single v1 execution model for every ACP-backed harness.

  • Run Claude Code, Codex, Hermes, Kimi Code, OpenClaw, Pi, Pool, and RLM through the shared ACPHarness lifecycle.
  • Keep one ACP process, connection, and native agent session alive for the complete rollout.
  • Remove the one-shot ACP runner, file-backed session_path continuation, and stateless fallback.
  • Make harnesses declarative: each provides its command, environment, prompt, MCP ownership, and cleanup while the shared layer owns process and session lifetime.
  • Preserve exact provider replay state and require the resumed tool-use E2E to remain a single trace branch.
  • Keep ACP prompts non-empty and user-only; stacked PR Add native ACP session import #2348 adds capability-negotiated native history import instead of flattening prior assistant or system turns into a user prompt.
  • Isolate OpenClaw's writable skills per rollout while retaining the uploaded tree as an immutable staging cache.

Why

The harnesses previously mixed live sessions, one-shot processes, and file-backed resume. Rebuilding a conversation at those boundaries changed model-visible history and produced false branches even when the agent completed the task correctly.

With LiveACP as the common backend, every interaction segment continues on the same native session. The graph can therefore represent one append-only conversation, and harness-specific code no longer needs to emulate continuation.

Provider and agent differences remain local to their harnesses: Kimi and Pi select their transport, Hermes resolves its native catalog, OpenClaw supervises its Gateway, and Pool now uses the same live lifecycle as the other ACP agents.

Stack

Validation

  • 70 non-E2E v1 tests
  • Prime VM ACP resume validation, including Pool, RLM, and OpenClaw
  • OpenClaw per-rollout skill-isolation probe
  • Ruff check and format
  • ty pre-push parity check
  • git diff --check

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Comment thread verifiers/v1/harnesses/hermes_agent/harness.py
@macroscopeapp

macroscopeapp Bot commented Aug 7, 2026

Copy link
Copy Markdown

Approvability

Verdict: Needs human review

Major refactor replacing the ACP composition pattern with inheritance-based ACPHarness, removing one-shot launch capability, and restructuring 8+ harness implementations. Changes to shared infrastructure abstractions warrant human review.

You can customize Macroscope's approvability policy. Learn more.

Comment thread verifiers/v1/harnesses/hermes_agent/harness.py Outdated
Comment thread verifiers/v1/acp/__init__.py Outdated
Comment thread verifiers/v1/acp/__init__.py Outdated
@xeophon xeophon changed the title Fix Hermes Agent ACP resume Fix ACP trace linearity across harnesses Aug 10, 2026
Comment thread verifiers/v1/harnesses/openclaw/harness.py Outdated
Comment thread verifiers/v1/harnesses/openclaw/harness.py Outdated
Comment thread verifiers/v1/harnesses/openclaw/harness.py
Comment thread verifiers/v1/harnesses/openclaw/harness.py Outdated
@xeophon
xeophon force-pushed the fix/hermes-acp-resume branch from 2263061 to f471f80 Compare August 10, 2026 15:24
Comment thread verifiers/v1/dialects/chat.py
Comment thread verifiers/v1/harnesses/pi/harness.py Outdated
Comment thread verifiers/v1/harnesses/pi/harness.py Outdated
@xeophon
xeophon force-pushed the fix/hermes-acp-resume branch 4 times, most recently from 623522e to c65d7e7 Compare August 10, 2026 17:51
Comment thread verifiers/v1/harnesses/openclaw/harness.py Outdated
@xeophon
xeophon force-pushed the fix/hermes-acp-resume branch 4 times, most recently from 212f5db to add2799 Compare August 11, 2026 08:06
Comment thread verifiers/v1/harnesses/hermes_agent/harness.py

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9c027ec. Configure here.

Comment thread verifiers/v1/harnesses/hermes_agent/harness.py Outdated
Comment thread verifiers/v1/harnesses/kimi_code/harness.py
Comment thread verifiers/v1/harnesses/kimi_code/harness.py
@xeophon
xeophon force-pushed the fix/hermes-acp-resume branch from d37b717 to cdbd9fd Compare August 13, 2026 12:51
Comment thread verifiers/v1/acp/__init__.py
@xeophon
xeophon requested a review from hallerite August 13, 2026 14:18
@xeophon xeophon changed the title Fix ACP trace linearity across harnesses Run all ACP harnesses on persistent live sessions Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants