-
Notifications
You must be signed in to change notification settings - Fork 220
Add <veil>, an inline reveal/hide element for guided notes #2671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@rbeezer, I finally got some time to work on this. Let me know what you think. I am colorblind, so the colors may need adjusting. I don't know what goes into the schema, so I'll wait for some guidance on where I should begin. |
|
Some merge conflicts when I try to rebase this. Generally you should not need to merge master into your topic branch. Not sure if that is where the problem lies. Can you:
If that does not make sense, or sounds dangerous, we can walk through it during a drop-in? |
|
@rbeezer, It is scary, but I used the resolve conflict editor here and removed the |
|
@rbeezer. Just bumping this PR to see if you got a chance to try it out and if there was anything else I could do to modify or improve it. |
|
Sorry, I've been off-duty for about a month, and had forgotten the status on this one. If I remember right the lasst time I tried to grab thiis PR to review, I had even more trouble than the time before. The PR/branch should not show any merge commits, and really should be just a few commits (at most) based on a recent (most recent) commit that has been pushed to the repository. Are you able to make it to Monday Drop-In online sessions? They'll move to Tuesday in a couple weeks or so. |
|
@rbeezer |
Summary
This PR introduces a new PreTeXt element, , for hiding inline and block content until the button labelled "reveal" is clicked. This version focuses more on the HTML side of the element and only offers minimal support for print.
HTML
LaTeX/Print
Testing
sample-article.ptxcontaining a comprehensive list of test samples.No schema or publisher-variable changes are included in this PR; those can follow in a subsequent change.