Skip to content

update tests #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mplesha merged 7 commits into from
Feb 1, 2025
Merged

update tests #9

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8630b64
Update script_test.rb
mplesha Feb 1, 2025
587c0a7
Update script_test.rb
mplesha Feb 1, 2025
fb4d62c
Update script_test.rb
mplesha Feb 1, 2025
01ef16e
Update script_test.rb
mplesha Feb 1, 2025
044e881
Update script_test.rb
mplesha Feb 1, 2025
e86e116
Update script_test.rb
mplesha Feb 1, 2025
27d706e
Update script_test.rb
mplesha Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/tests/test/script_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ def test_without_approval_main

def test_approve_from_user
user_name = 'softservedata'
classic_require_code_owner_review = @obj.rules_required_pull_request_reviews('main').nil? || @obj.rules_required_pull_request_reviews('develop')["require_code_owner_reviews"]
classic_require_code_owner_review = @obj.rules_required_pull_request_reviews('main').nil?
pull_request_rulesets_rules = @obj.get_branch_ruleset('main')
rulesets_require_code_owner_review = pull_request_rulesets_rules&.find { |rule| rule['type'] == 'pull_request' }&.[]('parameters')&.[]('require_code_owner_review')
assert_not_nil(classic_require_code_owner_review || rulesets_require_code_owner_review, "We should not allow merge to main branch without approve from #{user_name}")
assert(classic_require_code_owner_review || rulesets_require_code_owner_review, "We should not allow merge to main branch without approve from #{user_name}")
end

def test_PR_template_present
Expand Down