Repository navigation
Preserve alias corrections for executable commands in fallback DSC ASTs - #2284
Merged
Christoph Bergmeister (bergmeister) merged 2 commits intoOct 28, 2026
Conversation
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code issues as per review comments
Preserve alias corrections for executable commands in fallback DSC ASTs
Oct 28, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are blocking approval.
No open issues 🎉
What changed in this PR
This PR refines the alias rule’s fallback DSC resource detection so executable commands retain their expected Get- corrections.
Changes:
- Treat subexpressions and array expressions as executable-context boundaries.
- Exclude redirected commands and commands outside standalone statement blocks from resource detection.
- Add regression coverage while preserving resource recognition inside conditional bodies.
| File | Description |
|---|---|
Tests/Rules/AvoidUsingAlias.tests.ps1 |
Tests executable-command corrections and conditional-body resource detection in fallback ASTs. |
Rules/AvoidAlias.cs |
Tightens checks that distinguish DSC resource declarations from executable commands. |
Review effort: Balanced
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
October 28, 2026 17:27
Christoph Bergmeister (bergmeister)
requested a review
from a team
as a code owner
October 28, 2026 17:27
Christoph Bergmeister (bergmeister)
removed this pull request from stack #2285
October 28, 2026 17:27
Christoph Bergmeister (bergmeister)
merged commit Oct 28, 2026
26f025c
into
copilot/fix-auto-correct-aliases
8 checks passed
Christoph Bergmeister (bergmeister)
deleted the
copilot/fix-comments-in-review-thread
branch
October 28, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fallback configuration ASTs could misclassify executable commands as DSC resource declarations, suppressing expected
Get-corrections.These executable commands retain their
Get-Verbcorrections; resource-shaped commands inside conditional bodies remain recognized.