Repository navigation
Preserve branch indentation after multiline conditions - #2271
Merged
Christoph Bergmeister (bergmeister) merged 2 commits intoOct 28, 2026
Conversation
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code for review comments and add regression tests
Preserve branch indentation after multiline conditions
Oct 28, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the branch-indentation formatting change.
No open issues 🎉
What changed in this PR
Fixes PlaceCloseBrace formatting so branches following multiline conditions align with the closing brace rather than the condition’s continuation line.
Changes:
- Uses the closing brace’s indentation when it is on its own line, preserving the existing fallback otherwise.
- Adds regression tests for root-level and nested multiline
ifconditions.
| File | Description |
|---|---|
| Tests/Rules/PlaceCloseBrace.tests.ps1 | Adds root-level and nested branch-indentation regression tests. |
| Rules/PlaceCloseBrace.cs | Uses standalone closing-brace indentation for the following branch. |
Review effort: Balanced
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
October 28, 2026 11:56
Christoph Bergmeister (bergmeister)
requested a review
from a team
as a code owner
October 28, 2026 11:56
Christoph Bergmeister (bergmeister)
removed this pull request from stack #2272
October 28, 2026 12:09
Christoph Bergmeister (bergmeister)
merged commit Oct 28, 2026
810f339
into
copilot/ignore-onelineblock-correction
9 checks passed
Christoph Bergmeister (bergmeister)
deleted the
copilot/fix-code-for-review-comments
branch
October 28, 2026 12:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlaceCloseBracecould misindent a branch when the opening-brace line was part of a multiline condition. The formatter used that continuation line’s indentation instead of the closing brace’s indentation.The formatter now places
elseat the same indentation as}.