Apply AlignAssignmentStatement overhaul from PR #2132#2166
Closed
Apply AlignAssignmentStatement overhaul from PR #2132#2166
Conversation
Co-authored-by: andyleejordan <2226434+andyleejordan@users.noreply.github.com>
Co-authored-by: andyleejordan <2226434+andyleejordan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
andyleejordan
March 17, 2026 23:40
View session
Member
|
Copilot bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the
AlignAssignmentStatementrule rewrite from PR #2132 to fix several correctness and performance issues in hashtable alignment, and adds enum member value alignment.Rule fixes
=: e.g.($Key = 5) = "Value"previously causedStart position cannot be before End position— the rule was finding the wrong=tokenKey <#comment#> = "Value"had the comment stripped during auto-correctionNew features
CheckEnums,IncludeValuelessEnumMembers,AlignEnumMemberWithInterveningComment)AlignHashtableKvpWithInterveningCommentsetting to opt into aligning KVPs with intervening commentsBreaking change
All new settings default to
$true. PreviouslyCheckHashtabledefaulted to$false, so the rule was effectively a no-op by default; enabling it now does something meaningful.Also fixed
Minor typos in comments and docs (
trvially→trivially,it's→its,Enum's→Enums).