Suppress MAR fallback noise in Save/Install and remove test-oriented information output#2014
Open
SydneyhSmith with Copilot wants to merge 4 commits into
Open
Suppress MAR fallback noise in Save/Install and remove test-oriented information output#2014SydneyhSmith with Copilot wants to merge 4 commits into
SydneyhSmith with Copilot wants to merge 4 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
3 tasks
Copilot
AI
changed the title
[WIP] Fix multiple Cmdlets emitting unneeded logs and errors
Suppress MAR fallback noise in Save/Install and remove test-oriented information output
Jul 21, 2026
adityapatwardhan
approved these changes
Jul 23, 2026
Member
|
/azp run |
adityapatwardhan
marked this pull request as ready for review
July 23, 2026 17:49
adityapatwardhan
requested review from
alerickson,
anamnavi and
shammu1
as code owners
July 23, 2026 17:49
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR reduces end-user noise during multi-repository Save/Install scenarios by treating container-registry (MAR) “not found” responses as normal per-repository misses (instead of user-visible errors), and removes test-oriented Information-stream output from the container registry auth flow.
Changes:
- Reclassified container registry
ResourceNotFoundExceptionerrors inGetHttpResponseJObjectUsingDefaultHeaders(...)asPackageNotFound/ObjectNotFoundto align with fallback search behavior. - Replaced container registry auth-path
WriteInformation(...)withWriteDebug(...)to avoid Information-stream noise in normal cmdlet usage. - Updated Save/Install/Publish tests to assert no extra error/info output for successful fallback scenarios.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/code/ContainerRegistryServerAPICalls.cs | Adjusts container registry not-found error classification for fallback behavior; removes Information-stream output from auth flow. |
| test/SavePSResourceTests/SavePSResourceLocal.Tests.ps1 | Updates expectations so successful fallback produces no per-repo error noise. |
| test/InstallPSResourceTests/InstallPSResourceRepositorySearching.Tests.ps1 | Updates expectations for multi-repo search to avoid MAR “miss” errors when a lower-priority repo succeeds. |
| test/PublishPSResourceTests/PublishPSResourceContainerRegistryServer.Tests.ps1 | Removes reliance on Information-stream internals for registry-auth assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
adityapatwardhan
requested changes
Jul 23, 2026
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
MARis searched before other repositories, normal404 Not Foundresponses for packages not present in MAR were being emitted as user-visible errors, even when a later repository could satisfy the request. In addition, container registry auth-path internals were emitting Information-stream messages used only by tests.Container registry fallback error classification
ContainerRegistryServerAPICalls.GetHttpResponseJObjectUsingDefaultHeaders(...)to classifyResourceNotFoundExceptionas:FullyQualifiedErrorId = "PackageNotFound"ErrorCategory = ObjectNotFound404behavior with existing fallback logic so per-repository misses do not surface as misleading user errors during multi-repo search.Removed test-only Information stream output
WriteInformation("Value of isRepositoryUnauthenticated: ...")withWriteDebug(...)in container registry auth flow.Adjusted affected tests to match intended behavior