feat(prediction): support dynamic list height and remove history caps#5135
Open
Konstantin-Glukhov wants to merge 1 commit intoPowerShell:masterfrom
Open
feat(prediction): support dynamic list height and remove history caps#5135Konstantin-Glukhov wants to merge 1 commit intoPowerShell:masterfrom
Konstantin-Glukhov wants to merge 1 commit intoPowerShell:masterfrom
Conversation
Replace hardcoded prediction list limits with user-configurable sizing. Summary: - Remove the fixed 10-line cap and legacy auto-adjustment logic - Prediction list height and capacity now scale based on user settings - History suggestions are no longer artificially capped when plugins are active Key changes: - Convert ListMaxCount and HistoryMaxCount into dynamic properties on PredictionListView - Introduce layout constraints: - PhysicalMax: based on console buffer height (-2 for jitter protection) - PredictionViewHeight: limited by screen space and list capacity - HistoryMaxCount: adjusted to fill the visible view - Remove history cap in AggregateSuggestions (previously limited to 3) Configuration: Add new PSConsoleReadLineOptions properties: - PredictionViewHeight: visible list height - PredictionListCount: total scrollable items - PredictionHistoryCount: history fetch limit Signed-off-by: Konstantin Glukhov <KGlukhov@Hotmail.com>
Author
|
@microsoft-github-policy-service agree |
1 similar comment
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded prediction list limits with user-configurable sizing.
Summary:
Key changes:
Configuration:
Add new PSConsoleReadLineOptions properties:
PredictionViewHeight: visible list height
PredictionListCount: total scrollable items
PredictionHistoryCount: history fetch limit
PR has a meaningful title
Summarized changes
Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
User-facing changes
Microsoft Reviewers: Open in CodeFlow