Add unit tests and fix found issues#11
Merged
Merged
Conversation
98 tests covering auth, dashboard, items, users, categories, transactions, and stats routes. Includes edge cases for nonexistent IDs, invalid inputs, search/filter/sort, and price-to-cents conversions.
db.get() returns None for missing IDs; accessing item.name on None raises AttributeError and crashes with 500. Return 404 instead.
db.delete(None) raises InvalidRequestError and crashes with 500. Return 404 when the item does not exist.
db.get() returns None for missing IDs; accessing user.name on None raises AttributeError and crashes with 500. Return 404 instead.
int(request.form['card_id']) raises ValueError when the badge scanner submits a non-numeric value, crashing with 500. Return 400 instead.
db.get() returns None for missing IDs; accessing category.name on None raises AttributeError and crashes with 500. Return 404 instead.
db.delete(None) raises InvalidRequestError and crashes with 500. Return 404 when the category does not exist.
int(request.args.get('page', 1)) raises ValueError when ?page=abc is
passed, crashing both /transactions and /transactions/rows with 500.
Return 400 instead.
marvelous
approved these changes
Jun 4, 2026
marvelous
left a comment
marvelous
left a comment
Contributor
There was a problem hiding this comment.
not reviewed: tests/test_admin_*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.