fix(mcp): use plugin uninstall command for Claude Code and Codex#436
Open
posthog[bot] wants to merge 1 commit intomainfrom
Open
fix(mcp): use plugin uninstall command for Claude Code and Codex#436posthog[bot] wants to merge 1 commit intomainfrom
posthog[bot] wants to merge 1 commit intomainfrom
Conversation
PR #428 migrated addServer to the plugin interface but left removeServer calling the legacy mcp remove subcommand, which fails deterministically with "No user-scoped MCP server found". Add uninstallPlugin to the PluginCapable interface and route removeServer through it for both clients, treating not-installed stderr as benign success. Generated-By: PostHog Code Task-Id: 3774ac44-a10d-4f37-b5c2-fa82c315ec72
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude mcp remove --scope user posthogrejects withNo user-scoped MCP server found.addServerto the plugin interface (claude plugin install) but leftremoveServercalling the legacymcp removesubcommand. Same asymmetry existed inCodexMCPClient.uninstallPlugin()to thePluginCapableinterface and routesremoveServerthrough it for both clients, mirroring howaddServerdelegates toinstallPlugin. Treats "not installed" / "not found" / "does not exist" / "no such plugin" stderr as benign success, symmetric withinstallPlugin's handling of "already installed".019df89b-3f44-7791-85c4-6be1b9fe924a.Test plan
pnpm typecheckpassesclaude-code.test.tsandcodex.test.tsNo user-scoped MCP server founderrorclaude plugin uninstall posthog,codex plugin marketplace remove PostHog/ai-plugin); if either uses a different verb, it's a one-string fix per clientGenerated-By: PostHog Code
Task-Id: 3774ac44-a10d-4f37-b5c2-fa82c315ec72