Skip to content

chore: add PHP formatting check#163

Merged
marandaneto merged 2 commits into
mainfrom
chore/add-php-format-check
Jun 12, 2026
Merged

chore: add PHP formatting check#163
marandaneto merged 2 commits into
mainfrom
chore/add-php-format-check

Conversation

@marandaneto

Copy link
Copy Markdown
Member

💡 Motivation and Context

Add a PHP formatting check to CI so PSR-12 auto-fixable formatting issues are caught before merge.

💚 How did you test it?

  • vendor/bin/phpcs --standard=phpcs.xml test/FeatureFlagEvaluationsTest.php
  • actionlint .github/workflows/php.yml
  • git diff --check

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran pnpm changeset to generate a changeset file

@marandaneto marandaneto marked this pull request as ready for review June 12, 2026 06:07
@marandaneto marandaneto requested a review from a team as a code owner June 12, 2026 06:07
@marandaneto marandaneto enabled auto-merge (squash) June 12, 2026 06:07
@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
.github/workflows/php.yml:102
The `--report=summary` flag is a `phpcs` option and is not supported by `phpcbf`. PHP_CodeSniffer prints a "NOTE: The --report and --report-file options are not supported by PHPCBF." message at runtime and ignores it, so the step still works, but the flag is superfluous and can confuse readers into thinking it controls `phpcbf`'s output format.

```suggestion
          php phpcbf.phar --standard=phpcs.xml --no-colors || phpcbf_status=$?
```

Reviews (1): Last reviewed commit: "chore: add PHP formatting check" | Re-trigger Greptile

Comment thread .github/workflows/php.yml Outdated
@marandaneto marandaneto merged commit c437178 into main Jun 12, 2026
18 checks passed
@marandaneto marandaneto deleted the chore/add-php-format-check branch June 12, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants