Skip to content

fix: render branch creation dialog in TaskInput screen#1326

Open
CaioDGallo wants to merge 2 commits intoPostHog:mainfrom
CaioDGallo:fix/branch-creation-dialog
Open

fix: render branch creation dialog in TaskInput screen#1326
CaioDGallo wants to merge 2 commits intoPostHog:mainfrom
CaioDGallo:fix/branch-creation-dialog

Conversation

@CaioDGallo
Copy link
Contributor

@CaioDGallo CaioDGallo commented Mar 24, 2026

Problem

  • when clicking to "Create a new branch" on the BranchSelector component of the TaskInput page, nothing happens because the GitBranchDialog is never rendered in this flow.

Closes #1205

Changes

  • Added GitBranchDialog component to the TaskInput screen
  • Handled branch name sanitization and branch creation logic for this step (integrated with useGitInteractionStore props)
  • Added branch-here to GitActionType to fix linter issue
  • Extracted branch sanitize/validate/create flow into shared branchCreation utility used by both TaskInput and useGitInteraction (no intended behavior change).

How did you test this?

Manually

@CaioDGallo
Copy link
Contributor Author

Hi @charlesvien , I submitted this PR to fix #1205. The "Create new branch" dialog wasn't rendering on the TaskInput screen because GitInteractionHeader (which hosts the dialog) is only mounted in the task detail view. The fix adds the dialog rendering directly in TaskInput, driven by the existing gitInteractionStore.

Happy to hear your thoughts when you have time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If I am on Local and click "Create a new branch" nothing happens

1 participant