Skip to content

fix: Fix single-select checkbox state in planning mode#1312

Merged
charlesvien merged 1 commit intomainfrom
03-20-fix_single-select_checkbox_state_in_planning_mode
Mar 23, 2026
Merged

fix: Fix single-select checkbox state in planning mode#1312
charlesvien merged 1 commit intomainfrom
03-20-fix_single-select_checkbox_state_in_planning_mode

Conversation

@charlesvien
Copy link
Member

@charlesvien charlesvien commented Mar 20, 2026

Problem

In single-select mode, clicking the "Other" option enters edit mode without clearing the previous selection, and typing auto-checks "Other" without clearing others so you end up with two items checked. Then you can't uncheck either because single-select toggleCheck always re-selects the clicked item.

image.png

Changes

  1. Allow unchecking a selected option in single-select mode (toggleCheck)
  2. Clear other selections when clicking a custom-input option in single-select mode (handleClick, selectCurrent)
  3. Clear other selections when auto-checking custom input on text entry in single-select mode (handleCustomInputChange)

How did you test this?

Manually

@charlesvien charlesvien changed the title Fix single-select checkbox state in planning mode fix: Fix single-select checkbox state in planning mode Mar 20, 2026
Copy link
Member Author

charlesvien commented Mar 20, 2026

@charlesvien charlesvien marked this pull request as ready for review March 21, 2026 06:11
@charlesvien charlesvien force-pushed the 03-20-fix_single-select_checkbox_state_in_planning_mode branch from 1061b21 to 06e2ac2 Compare March 23, 2026 11:31
Copy link
Member Author

charlesvien commented Mar 23, 2026

Merge activity

  • Mar 23, 1:28 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 23, 1:28 PM UTC: @charlesvien merged this pull request with Graphite.

@charlesvien charlesvien merged commit 091398a into main Mar 23, 2026
15 checks passed
@charlesvien charlesvien deleted the 03-20-fix_single-select_checkbox_state_in_planning_mode branch March 23, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants