Stop submit if empty without required#116
Open
kingsj0405 wants to merge 3 commits intoPoolC:masterfrom
kingsj0405:feature/issue_113-CodeMirror_hide_textarea
Open
Stop submit if empty without required#116kingsj0405 wants to merge 3 commits intoPoolC:masterfrom kingsj0405:feature/issue_113-CodeMirror_hide_textarea
kingsj0405 wants to merge 3 commits intoPoolC:masterfrom
kingsj0405:feature/issue_113-CodeMirror_hide_textarea
Conversation
The main problem is textarea is hide when check required content. But codemirror don't have robust solution about that and give up. So I check empty content without required as wordaround.
hellodhlyn
requested changes
Mar 2, 2018
template/article_editor.html
Outdated
| .val(editor.getValue()); | ||
| } | ||
| ) | ||
| $('form').submit(function(e) { |
Member
Member
Author
|
일단 코드리뷰는 수정했는데 린트 저렇게 빡센 거 실화인가요... |
Follow Code Review
Member
Author
|
수정완료 |
hellodhlyn
approved these changes
Mar 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
스택오버플로우 글에서 textarea가 required를 체크할 때 hide되어 있는 것이 문제라고 해서 코드를 보니까 다음과 같이 되어 있습니다.
CodeMirror 이슈에서 CodeMirror Maintainer가 이 이슈는 포기한 걸 보고 workaround로 해결했습니다.