refactor: Experimental optimizations#47
Draft
crueter wants to merge 1 commit into
Draft
Conversation
Some experimental and presently untested optimizations to a few of the scripts. Most of this is bypassing Pydantic's incredibly slow model parsing. - Larger chunk sizes for download writes, which should reduce syscall overload. - Avoid pydantic's slow parse_obj method, might be faster? - Rewrote Neoforge generation to write a dict directly rather than deal with Pydantic nonsense - Got rid of the thousands of sort operations on recommended_versions - Faster dict conversion to sidestep Pydantic's recursive parsing Python sucks. Signed-off-by: crueter <crueter@eden-emu.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some experimental and presently untested optimizations to a few of the scripts. Most of this is bypassing Pydantic's incredibly slow model parsing.
Python sucks.