Skip to content

Fix Derma control bases and type ControlPanel:AddControl results - #21

Open
Pollux12 wants to merge 5 commits into
betafrom
fix/derma-control-bases
Open

Pollux12 wants to merge 5 commits into
betafrom
fix/derma-control-bases

Conversation

@Pollux12

@Pollux12 Pollux12 commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Derive DTextEntry from TextEntry, and DCheckBoxLabel, DFileBrowser and DNumPad from DPanel, matching their real bases so inherited methods resolve.
  • Type ControlPanel:AddControl results by control name (textbox, checkbox, slider, numpad, color, propselect, matselect, ropematerial, listbox, combobox and more), instead of returning a plain panel.
  • Declare the panel classes those controls return that were missing: RopeMaterial (a MatSelect), CtrlNumPad and CtrlColor, with their fields and methods.
  • Let skins add their own named colours to SKIN.Colours, read with derma.GetColor or SKIN.Colours.
  • Let ents.Create return NULL for known engine entity classes too, since creation can still fail.

RetriggerConfidence Score: 5/5

This PR appears safe to merge; no actionable defects were established.

Summary

This PR improves the types exposed for Derma controls.

  • Control panel names now point to their specific control types.
  • Four Derma controls now name their actual base classes.
  • Skins can now declare extra named colours.
  • Known entity classes can now return NULL in the type notes.

No actionable issues were established.

Reviews (1) · Last reviewed commit: "Declare the panel classes ControlPanel:A..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant