Skip to content

Align CHIP calibration to FY2024#8180

Merged
MaxGhenis merged 6 commits intoPolicyEngine:mainfrom
daphnehanse11:codex/issue-8096-chip-fy2024
May 5, 2026
Merged

Align CHIP calibration to FY2024#8180
MaxGhenis merged 6 commits intoPolicyEngine:mainfrom
daphnehanse11:codex/issue-8096-chip-fy2024

Conversation

@daphnehanse11
Copy link
Copy Markdown
Collaborator

Fixes #8096.

Summary

  • Adds FY2024 MACPAC Exhibit 33 spending rows to CHIP total, federal, state, Medicaid-expansion, separate-CHIP, and program-admin calibration parameters.
  • Adds FY2024 MACPAC Exhibit 32 enrollment rows to total, Medicaid-expansion, and separate-CHIP enrollment calibration parameters.
  • Updates per_capita_chip_gross documentation now that 2024 net spending, enrollment, and cost-sharing offsets are aligned to FY2024.
  • Updates per-capita CHIP tests and adds representative FY2024 gross checks for MO, FL, TX, and NY.

Sources

Tests

  • uv run --extra dev ruff format policyengine_us/variables/gov/hhs/chip/per_capita_chip_gross.py
  • uv run python -m policyengine_core.scripts.policyengine_command test policyengine_us/tests/policy/baseline/gov/hhs/chip/per_capita_chip.yaml policyengine_us/tests/policy/baseline/gov/hhs/chip/per_capita_chip_gross.yaml -c policyengine_us
  • uv run pytest policyengine_us/tests/test_parameter_files.py -q
  • uv run --extra dev ruff check .

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d55cd4f) to head (6311d5e).
⚠️ Report is 91 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8180   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         1    -1     
  Lines           35        21   -14     
=========================================
- Hits            35        21   -14     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@daphnehanse11
Copy link
Copy Markdown
Collaborator Author

Initial review pass before edits:

  • Checked the CHIP FY2024 calibration parameter additions, existing parameter metadata/reference surfaces, per_capita_chip_gross period handling, the zero-enrollment guard, and the new CHIP test periods/error margins.
  • I do not see a functional blocker yet.
  • I did spot a small test-style cleanup opportunity: keep the new per_capita_chip case appended after existing cases and normalize the newly added CHIP test names to the numbered Case N, ... pattern.

I am patching those low-risk cleanups in a fresh detached /tmp worktree and will run the narrow CHIP tests/lint before pushing.

@daphnehanse11
Copy link
Copy Markdown
Collaborator Author

Code-quality pass pushed in c3982ea. I tightened the CHIP calibration parameter metadata so the labels/descriptions match the total/enrollment series more specifically. Focused CHIP YAML tests pass locally: 9 passed. The failing Full Suite states-non-ny-shard-1 job is unrelated to this PR; it is a NJ/NM/OH state income-tax baseline cluster that reproduces outside the CHIP calibration files.

@daphnehanse11 daphnehanse11 marked this pull request as ready for review April 30, 2026 18:02
@daphnehanse11 daphnehanse11 requested a review from MaxGhenis April 30, 2026 18:23
@MaxGhenis
Copy link
Copy Markdown
Contributor

MaxGhenis commented May 5, 2026

Pushed a fix in 6311d5e for the Maryland denominator outlier.

MACPAC Exhibit 32's FY2024 Maryland row reports only 0.601k CHIP-funded children, while Exhibit 33 reports $682.9M in CHIP spending. Using that row directly made Maryland per-capita CHIP $1.136M. Since the FY2024 enrollment row is not comparable with the spending scope, this keeps Maryland's 2024 M-CHIP/total denominator on the prior same-scope 139k count until we have a comparable FY2024 denominator, and adds MD regression cases for both net and gross per-capita CHIP.

Local checks:

  • uv run python -m policyengine_core.scripts.policyengine_command test policyengine_us/tests/policy/baseline/gov/hhs/chip/per_capita_chip.yaml policyengine_us/tests/policy/baseline/gov/hhs/chip/per_capita_chip_gross.yaml -c policyengine_us -> 11 passed
  • .venv/bin/python -m pytest policyengine_us/tests/test_parameter_files.py policyengine_us/tests/code_health/parameters.py -q -> 3 passed

Copy link
Copy Markdown
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the Maryland FY2024 denominator fix and current CI. The CHIP calibration update is now scoped consistently and all checks pass.

@MaxGhenis MaxGhenis merged commit 0515026 into PolicyEngine:main May 5, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align CHIP spending, enrollment, and cost-sharing offsets to one fiscal year

2 participants