Open
Conversation
0c509a1 to
5579a5f
Compare
5579a5f to
207037d
Compare
Contributor
Author
|
Local paired build result using this us-data branch with PolicyEngine/policyengine-us#8170:
Calibration log from the local build:
There is no standalone LLC calibration target in this PR because IRS SOI Table 3.3 reports LLC only inside the combined nonrefundable education credit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
policyengine-usparameters instead of hardcoding statutory dollar amounts or ratesE87530for LLC-specific expenses where present and keep the release/fallback path compatible with current PE-US buildsPrimary Sources
education_tax_creditstarget, not a standalone LLC calibration target.Local Build Result
Built
EnhancedCPS_2024locally against PolicyEngine/policyengine-us#8170. Latest aggregate from the calibrated dataset:The local calibration log reports:
Dependency
Tests
uv run --no-sync ruff check policyengine_us_data/datasets/puf/puf.py policyengine_us_data/datasets/puf/uprate_puf.py tests/unit/datasets/test_puf_tuition.py tests/unit/datasets/test_uprate_puf.pyuv run --no-sync pytest tests/unit/datasets/test_puf_tuition.py tests/unit/datasets/test_uprate_puf.py -quv run --no-sync pytest tests/unit/calibration/test_loss_targets.py tests/unit/test_etl_irs_soi_overlay.py tests/unit/test_refresh_soi_table_targets.py tests/unit/test_extended_cps.py tests/unit/datasets/test_puf_tuition.py tests/unit/datasets/test_uprate_puf.py -qFixes #841