Blend SIPP and SCF financial asset imputations#839
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net_worth, so masked SCF receiver rows do not drop overlapping assetsnet_worthdirectly from the final mixed-source component formula, with nonet_worth_residual; the internal direct SCF net-worth prediction anchors proportional rebalancing of SCF-only leaves while preserving resource-tested policy leavesAGENTS.mdinstructions so future agent PRs use in-repo PolicyEngine branches rather than forksRefs #835.
Validation
uv run pytest tests/unit/test_asset_imputation.py tests/unit/calibration/test_source_impute.py tests/unit/datasets/test_cps_file_handles.pyuv run ruff format --check .uv run ruff check policyengine_us_data/utils/asset_imputation.py policyengine_us_data/datasets/cps/cps.py policyengine_us_data/calibration/source_impute.py tests/unit/test_asset_imputation.py tests/unit/calibration/test_source_impute.py tests/unit/datasets/test_cps_file_handles.pyuv run towncrier check --compare-with origin/maingit diff --check