Complete towncrier migration for versioning workflow#1522
Merged
nikhilwoodruff merged 1 commit intomainfrom Mar 8, 2026
Merged
Complete towncrier migration for versioning workflow#1522nikhilwoodruff merged 1 commit intomainfrom
nikhilwoodruff merged 1 commit intomainfrom
Conversation
nikhilwoodruff
force-pushed
the
fix/towncrier-versioning-workflow
branch
from
9f0cc93 to
4534263
Compare
The Makefile, pyproject.toml, and bump_version.py were already migrated to towncrier, but the versioning workflow still triggered on changelog_entry.yaml and used yaml-changelog. This meant changelog.d/ fragments never triggered version bumps or PyPI publishes. - Trigger on changelog.d/** and pyproject.toml instead of changelog_entry.yaml - Use towncrier build instead of yaml-changelog - Read version from pyproject.toml instead of setup.py in publish-git-tag.sh - Remove duplicate towncrier dep, drop yaml-changelog Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Makefile, pyproject.toml, and bump_version.py were already migrated to towncrier (fragments in
changelog.d/), but the versioning workflow still triggered onchangelog_entry.yamland usedyaml-changelog. This meant PRs withchangelog.d/fragments (like #1521) never triggered version bumps or PyPI publishes.Changes:
changelog.d/**andpyproject.tomlinstead ofchangelog_entry.yamltowncrier buildinstead ofyaml-changelogin the Versioning jobpyproject.tomlinstead ofsetup.pyinpublish-git-tag.shOnce merged, this should trigger a version bump and release covering all the pending
changelog.d/fragments (including the electricity/gas variables from #1521).Test plan
changelog.d/changes via the workflow path trigger)bump_version.pycorrectly infers minor bump from existing fragmentstowncrier buildconsumes fragments and updates CHANGELOG.md