Conversation
Contributor
Author
|
Superseded by PolicyEngine/policyengine-sim-api#705. The replacement keeps this temporary Stage 12 behavior in the simulation executor: it packages the reviewed code/name/coordinate data, detects LAD22 or LAD23 from the complete dataset's actual la_code_oa values, and carries that selection as typed artifact metadata. No UK-data publication is required for this stage. |
Contributor
Author
|
Update: the replacement simulation API work is now PolicyEngine/policyengine-sim-api#706. GitHub closed #705 when its branch was renamed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #488
Creates complete LAD22 and LAD23 display-metadata CSVs without changing the legacy local_authorities_2021.csv or local_authority_weights.h5 files used by API v1. The LAD22 file restores the 17 English predecessor districts; the LAD23 file contains their four successors. Both include all 11 Northern Ireland districts and unique integer map coordinates.
The established private-data upload workflow now publishes both assets.
Test plan: