Wait for Cloud Run routing convergence during promotion - #700
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #699
Summary
Cloud Run can continue routing requests to the previous revision briefly after its service status reports that 100% of traffic has moved. The production deployment workflow previously made one immediate health request and restored the previous revision when that request reached the old revision.
This change lets stable and custom hostname checks wait for that documented routing transition without hiding unrelated deployment failures.
Changes
Testing
uv run pytest tests/test_deployment_assets.py -v— 25 passedshellcheck .github/scripts/cloud-run-simulation-entry-smoke.shactionlint .github/workflows/simulation-deploy.reusable.ymlgit diff --check