feat: Add adds/subtracts to variable metadata types and adapter#781
Open
anth-volk wants to merge 3 commits intomove-to-api-v2from
Open
feat: Add adds/subtracts to variable metadata types and adapter#781anth-volk wants to merge 3 commits intomove-to-api-v2from
anth-volk wants to merge 3 commits intomove-to-api-v2from
Conversation
Map adds/subtracts from the v2 API through to VariableMetadata so VariableArithmetic can render variable breakdown trees. Includes adapter tests and mock factory updates. Closes #780 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #780
Summary
adds: string[] | nullandsubtracts: string[] | nulltoV2VariableMetadatatypeadds?: string[]andsubtracts?: string[]toVariableMetadatatypeMetadataAdapter.variableFromV2()with null → undefined conversioncreateMockVariablefactory withadds: null, subtracts: nulldefaultsTest plan
given V2 variable with null adds then converts to undefinedgiven V2 variable with null subtracts then converts to undefinedgiven V2 variable with adds array then preserves arraygiven V2 variable with subtracts array then preserves arraygiven V2 variable with both adds and subtracts then preserves bothgiven V2 variable with empty adds array then preserves empty array🤖 Generated with Claude Code