Send tax_benefit_model_name instead of country_id for parameter tree endpoints#775
Closed
anth-volk wants to merge 3 commits intomove-to-api-v2from
Closed
Send tax_benefit_model_name instead of country_id for parameter tree endpoints#775anth-volk wants to merge 3 commits intomove-to-api-v2from
anth-volk wants to merge 3 commits intomove-to-api-v2from
Conversation
… tree endpoints Update fetchParameterChildren and fetchParametersByName to send tax_benefit_model_name instead of country_id, aligning with API changes that unify all metadata endpoints to use tax_benefit_model_name. Closes #774 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by the country_id standardization work on feat/v1-v2-migration-script. The frontend now sends country_id everywhere (including parameter tree endpoints) and the API resolves it to the latest model version server-side, eliminating the need for the frontend to know about tax_benefit_model_name at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchParameterChildrento sendtax_benefit_model_namequery param instead ofcountry_idfetchParametersByNameto sendtax_benefit_model_namein POST body instead ofcountry_idcountryIdto model name happens internally viagetModelName()Test plan
Blocked by: PolicyEngine/policyengine-api-v2-alpha#98
Closes #774
🤖 Generated with Claude Code