Skip to content

Fix observability middleware test isolation - #3857

Merged
anth-volk merged 1 commit into
masterfrom
fix/observability-context-test-isolation
Sep 29, 2026
Merged

anth-volk merged 1 commit into
masterfrom
fix/observability-context-test-isolation

Conversation

@anth-volk

Copy link
Copy Markdown
Collaborator

Fixes #3856

Summary

This PR removes unrelated deployment configuration assumptions from two Flask observability middleware tests. The assertions continue to verify request metadata and observability_id propagation without requiring a specific simulation entrypoint.

The previous assertions caused deployment run 36602925386 to fail when the staging environment supplied SIM_ENTRYPOINT=cloud_run_simulation_entrypoint.

Changes

Testing

  • env SIM_ENTRYPOINT=cloud_run_simulation_entrypoint uv run --frozen pytest tests/unit/routes/test_migration_context_logging.py -q — 26 passed
  • uv run --frozen ruff format --check tests/unit/routes/test_migration_context_logging.py
  • uv run --frozen ruff check tests/unit/routes/test_migration_context_logging.py
  • make format

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.65%. Comparing base (ca912a3) to head (35e56d0).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3857       +/-   ##
===========================================
+ Coverage   45.76%   87.65%   +41.89%     
===========================================
  Files         182      197       +15     
  Lines       10812    11952     +1140     
  Branches     1837     2092      +255     
===========================================
+ Hits         4948    10477     +5529     
+ Misses       5456      901     -4555     
- Partials      408      574      +166     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anth-volk
anth-volk marked this pull request as ready for review September 29, 2026 18:15
@anth-volk
anth-volk merged commit dc8b5a0 into master Sep 29, 2026
14 checks passed

This branch was successfully deployed

1 active deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Isolate observability middleware tests from simulation entrypoint configuration

1 participant