Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3855 +/- ##
===========================================
+ Coverage 45.76% 87.68% +41.92%
===========================================
Files 182 198 +16
Lines 10812 12010 +1198
Branches 1837 2106 +269
===========================================
+ Hits 4948 10531 +5583
+ Misses 5456 901 -4555
- Partials 408 578 +170 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…-1-2-api # Conflicts: # tests/unit/routes/test_calculate_error_statuses.py # tests/unit/services/test_economy_service.py
Collaborator
Author
|
CI follow-up completed in commits
Validation:
The only remaining unsuccessful check is the live simulation compatibility check because the deployed simulation service does not yet advertise PolicyEngine.py 6.1.2. No service was deployed or merged as part of this fix. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
policyengine[models]==6.1.2, which selects PolicyEngine Core 3.32.5, PolicyEngine US 2.2.1, PolicyEngine UK 2.90.2, and spm-calculator 1.0.0.uv.lock, verify all five installed distributions against the bundle manifest, and report the US and UK certified data releases.This supersedes #3837 as a clean implementation from current
master. It does not reuse the implementation logic or commits from #3837.PolicyEngine 6 behavior covered here
PolicyEngine.py 6.1.2 identifies the exact SPM forecast file and default scenario used by the installed US model. API v1 resolves those settings before submitting an economy calculation. It rejects a worker that reports different settings, and it validates the forecast, scenario, year, and geography receipts in completed results before caching them.
The bundle also changes the installed public model catalog. The compatibility fixture now records 7,046 variables, 29,118 parameter nodes, 103,705 parameters, and 1,192,826 parameter values.
Simulation API relationship
PolicyEngine/policyengine-sim-api#703 contains the corresponding worker update to PolicyEngine.py 6.1.2. The two PRs can be reviewed independently. This PR does not merge or deploy #703, and opening this PR does not roll out either service.
Until a compatible worker is deployed, API v1 returns
SPM_CONFIGURATION_UNAVAILABLEfor affected US economy requests instead of submitting them to an incompatible worker. The live worker compatibility check may therefore remain unsuccessful while #703 is only a PR.Commits
Testing
uv lock --checkruff check .github/find-api-model-versions.py policyengine_api tests