Fix pre-submission imputation and evaluation correctness - #219

Draft

juaristi22 wants to merge 25 commits into

mainfrom

fix/publication-correctness

Commits on Sep 21, 2026

Give each per-variable QRF model its own seed

vahid-ahmadi
authored and
juaristi22
committed
73f788f
Fix issues from review: bound QRF seeds and preserve tuning streams
juaristi22
committed
146f0c4
Fail loudly on an unknown variable and an invalid seed

vahid-ahmadi
authored and
juaristi22
committed
a8c94bd
Prune failed Matching trials instead of scoring the training mean

vahid-ahmadi
authored and
juaristi22
committed
79ac62b
Fix issues from review: track Matching prediction failures
juaristi22
committed
5a4f8d6
Reset the failure counter, report the cause, expose it on the result

vahid-ahmadi
authored and
juaristi22
committed
6a94c6d
Fix indentation that moved a raise out of its except block

vahid-ahmadi
authored and
juaristi22
committed
09ba11b
Fix issues from review: restore lint compatibility and preserve matching failure metadata
juaristi22
committed
62d03ce
Declare subpackages instead of shipping the source tree as package data

vahid-ahmadi
authored and
juaristi22
committed
d6ca1d5
Fix issues from review: format documentation examples
juaristi22
committed
60f822a
Add per-version classifiers, an author email, and a find exclude

vahid-ahmadi
authored and
juaristi22
committed
6a0e9b7
Fix tests that pass for the wrong reason, and export ZeroInflatedImputer

vahid-ahmadi
authored and
juaristi22
committed
ae2d831
Allow Matching's own message in the missing-predictor test

vahid-ahmadi
authored and
juaristi22
committed
9a9929c
Fix issues from review: preserve public config compatibility
juaristi22
committed
72542b3
Act on review: loosen frozen tests, correct the weight docstring

vahid-ahmadi
authored and
juaristi22
committed
94fb136
Give each per-variable QRF model its own seed

vahid-ahmadi
authored and
juaristi22
committed
e4fc210
Prune failed Matching trials instead of scoring the training mean

vahid-ahmadi
authored and
juaristi22
committed
e9fec87
Fix pre-submission imputation and evaluation correctness
juaristi22
committed
1309a2a
Fix issues from review: preserve numeric and weight semantics
juaristi22
committed
398336b
Fix issues from review: repair prediction contracts and compatibility
juaristi22
committed
8fbd31e
Integrate repaired QRF seed handling from PR #214
juaristi22
committed
9af2ba6
Integrate Matching failure reporting from PR #215
juaristi22
committed
68d6acb
Integrate packaging corrections from PR #216
juaristi22
committed
17d8699
Integrate public exports and compatibility cleanup from PR #217
juaristi22
committed
5dfc865
Fix issues from review: use native R donation-class argument
juaristi22
committed
296e47d

Navigation Menu

Fix pre-submission imputation and evaluation correctness - #219

Fix pre-submission imputation and evaluation correctness#219
juaristi22 wants to merge 25 commits into
mainfrom
fix/publication-correctness

Commits on Sep 21, 2026

Give each per-variable QRF model its own seed

Fix issues from review: bound QRF seeds and preserve tuning streams

Fail loudly on an unknown variable and an invalid seed

Prune failed Matching trials instead of scoring the training mean

Fix issues from review: track Matching prediction failures

Reset the failure counter, report the cause, expose it on the result

Fix indentation that moved a raise out of its except block

Fix issues from review: restore lint compatibility and preserve matching failure metadata

Declare subpackages instead of shipping the source tree as package data

Fix issues from review: format documentation examples

Add per-version classifiers, an author email, and a find exclude

Fix tests that pass for the wrong reason, and export ZeroInflatedImputer

Allow Matching's own message in the missing-predictor test

Fix issues from review: preserve public config compatibility

Act on review: loosen frozen tests, correct the weight docstring

Give each per-variable QRF model its own seed

Prune failed Matching trials instead of scoring the training mean

Fix pre-submission imputation and evaluation correctness

Fix issues from review: preserve numeric and weight semantics

Fix issues from review: repair prediction contracts and compatibility

Integrate repaired QRF seed handling from PR #214

Integrate Matching failure reporting from PR #215

Integrate packaging corrections from PR #216

Integrate public exports and compatibility cleanup from PR #217

Fix issues from review: use native R donation-class argument