Tag releases again

.github/publish-git-tag.sh

@@ -1,4 +1,24 @@
-#! /usr/bin/env bash
+#!/usr/bin/env bash
+# Tag the commit that published this version.
+#
+# Run from the publish job after the version bump has landed on main. Exits
+# non-zero if tagging fails, so a broken release is visible rather than silent.
+set -euo pipefail
 
-git tag `python .github/fetch_version.py`  # create a new tag
-git push --tags || true  # update the repository version
+PYTHON=$(command -v python || command -v python3)
+VERSION=$("$PYTHON" -c "import re, pathlib; print(re.search(r'^version\s*=\s*\"(\d+\.\d+\.\d+)\"', pathlib.Path('pyproject.toml').read_text(), re.M).group(1))")
+TAG="v${VERSION}"
+
+if git rev-parse -q --verify "refs/tags/${TAG}" >/dev/null; then
+  echo "Tag ${TAG} already exists locally; nothing to do."
+  exit 0
+fi
+
+if git ls-remote --exit-code --tags origin "refs/tags/${TAG}" >/dev/null 2>&1; then
+  echo "Tag ${TAG} already exists on the remote; nothing to do."
+  exit 0
+fi
+
+echo "Tagging ${TAG}"
+git tag "${TAG}"
+git push origin "${TAG}"

.github/workflows/versioning.yaml

@@ -49,6 +49,9 @@ jobs:
       name: Publish to PyPI
       if: (github.event.head_commit.message == 'Update package version')
       runs-on: ubuntu-latest
+      permissions:
+        contents: write
+        id-token: write
       steps:
         - name: Checkout code
           uses: actions/checkout@v6
@@ -68,11 +71,13 @@ jobs:
         - name: Build package
           run: |
             make build
-        - name: Publish a git tag
-          run: ".github/publish-git-tag.sh || true"
         - name: Publish to PyPI
           uses: pypa/gh-action-pypi-publish@release/v1
           with:
             user: __token__
             password: ${{ secrets.PYPI }}
             skip-existing: true
+        # After the upload, so a tag failure can never hold back a release.
+        # skip-existing above keeps a rerun safe.
+        - name: Publish a git tag
+          run: ".github/publish-git-tag.sh"

changelog.d/git-tags.fixed.md

@@ -0,0 +1 @@
+Release tagging now works: the tag script reads the version from pyproject.toml rather than a helper that never existed, and fails loudly instead of silently.