Repository navigation
Conversation
serabi
marked this pull request as ready for review
November 14, 2026 20:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
The goal of this PR is to add time-of-day conditions to the 21 grass encounters on Kanto Route 13 in Crystal. Right now none of them have a condition, so the morning, day and night tables all show up at once. For example, Chansey's three 1% slots add up to 3%, and Noctowl and Venonat show up during the day.
This adds
time-morningto encounters55979-55985,time-dayto55986-55992andtime-nightto55993-55999.Closes #1140.
References
https://github.com/pret/pokecrystal/blob/3c813b0b4d82b39bf62185aceffb76fd6026c70b/data/wild/kanto_grass.asm#L481-L507
55979-55999are those three tables, in the same order:https://github.com/PokeAPI/pokeapi/blob/8a92bfa7dab2f12b84b5d151562f9857c133ff30/data/v2/csv/encounters.csv#L52165-L52185
55978to56000:https://github.com/PokeAPI/pokeapi/blob/8a92bfa7dab2f12b84b5d151562f9857c133ff30/data/v2/csv/encounter_condition_value_map.csv#L15640-L15641
Testing
Built the local database before and after the change and checked the Route 13 location-area endpoint.
Crystal's grass encounters now total 100% in the morning, day and night.
All 69 tests passed, along with pre-commit, lint, formatting and type checks.
AI coding assistance disclosure
I used AI assistance from Claude Code (Claude Opus 5.5) to investigate the issue, compare PokeAPI's CSV records with Crystal's disassembled encounter table, and apply the fix. I then reviewed all of the code manually. All decisions made - and the PR text - are my own.
Contributor check list