Skip to content

fix: add time-of-day conditions to Crystal Route 13 - #1722

Open
serabi wants to merge 1 commit into
PokeAPI:masterfrom
serabi:fix/crystal-route-13-times
Open

serabi wants to merge 1 commit into
PokeAPI:masterfrom
serabi:fix/crystal-route-13-times

Conversation

@serabi

@serabi serabi commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Change description

The goal of this PR is to add time-of-day conditions to the 21 grass encounters on Kanto Route 13 in Crystal. Right now none of them have a condition, so the morning, day and night tables all show up at once. For example, Chansey's three 1% slots add up to 3%, and Noctowl and Venonat show up during the day.

This adds time-morning to encounters 55979-55985, time-day to 55986-55992 and time-night to 55993-55999.

Closes #1140.

References

Testing

Built the local database before and after the change and checked the Route 13 location-area endpoint.

Crystal's grass encounters now total 100% in the morning, day and night.

All 69 tests passed, along with pre-commit, lint, formatting and type checks.

AI coding assistance disclosure

I used AI assistance from Claude Code (Claude Opus 5.5) to investigate the issue, compare PokeAPI's CSV records with Crystal's disassembled encounter table, and apply the fix. I then reviewed all of the code manually. All decisions made - and the PR text - are my own.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@serabi
serabi marked this pull request as ready for review November 14, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kanto Route 13 encounter table missing time conditions for Crystal

1 participant