Add missing English effect_entries for as-one-glastrier and as-one-spectrier - #1620
Conversation
|
follow the format of the csv, prose text should be single line instead of spanning multi line, also disclose AI usage since the pr desc in comparison to the problem its solving is looking a bit bulky/ai generated |
|
Good call, fixed — I had concatenated the full effect text of Unnerve + Chilling Neigh/Grim Neigh across multiple paragraphs, which was overkill. Simplified both entries to a single line using the official in-game description instead ("This Ability combines the effects of both Calyrex's Unnerve Ability and Glastrier's/Spectrier's Chilling Neigh/Grim Neigh Ability"). Re: AI — yes, I used Claude as an assistant to move faster (research, drafting, running the test suite), but I reviewed and verified every change myself, including rebuilding the local DB and hitting the live endpoints to confirm the output before opening the PR. I didn't just hand this off and paste the result. |
|
Ability prose is often multiline, as can be seen with the very first ability. What it was set to before is perfectly fine, and is a bit clearer on the effects of the ability. Could you revert this recent commit and sync with the |
…ectrier Both abilities had zero rows in ability_prose.csv, so effect_entries was empty for them despite every other ability having at least an English entry. Fixes PokeAPI#1615
Use the official in-game description (both abilities combine Unnerve with Chilling Neigh or Grim Neigh) instead of concatenating the full effect text of each component ability across multiple paragraphs.
…line format" This reverts commit 66b5d40.
66b5d40 to
be951eb
Compare
|
Reverted and rebased onto master, thanks! |
|
Merging, thanks! |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
Problem
Fixes #1615.
as-one-glastrier(ability 266) andas-one-spectrier(ability 267) had zero rows indata/v2/csv/ability_prose.csv, soeffect_entrieswas empty for both, unlike every other ability which has at least an English entry.Fix
Added English (
local_language_id9) rows for both abilities, describing them as the combination of Unnerve with Chilling Neigh / Grim Neigh respectively (matching the official in-game description, see Bulbapedia), and reusing the existing English wording already in this CSV for Unnerve (127), Chilling Neigh (264), and Grim Neigh (265).I only added English entries — I didn't have a reliable source for official French wording so I left that out rather than guess.
Test plan
csv.DictReaderparses the file cleanly (809 rows, no errors).GET /api/v2/ability/as-one-glastrier/→effect_entriesnow has an English entry.GET /api/v2/ability/as-one-spectrier/→ same.manage.py test pokemon_v2passes (56 tests).