Skip to content

Add missing English effect_entries for as-one-glastrier and as-one-spectrier - #1620

Merged
Naramsim merged 3 commits into
PokeAPI:masterfrom
santichausis:data/as-one-ability-effect-entries
Aug 2, 2026
Merged

Add missing English effect_entries for as-one-glastrier and as-one-spectrier#1620
Naramsim merged 3 commits into
PokeAPI:masterfrom
santichausis:data/as-one-ability-effect-entries

Conversation

@santichausis

Copy link
Copy Markdown
Contributor

Problem

Fixes #1615.

as-one-glastrier (ability 266) and as-one-spectrier (ability 267) had zero rows in data/v2/csv/ability_prose.csv, so effect_entries was empty for both, unlike every other ability which has at least an English entry.

Fix

Added English (local_language_id 9) rows for both abilities, describing them as the combination of Unnerve with Chilling Neigh / Grim Neigh respectively (matching the official in-game description, see Bulbapedia), and reusing the existing English wording already in this CSV for Unnerve (127), Chilling Neigh (264), and Grim Neigh (265).

I only added English entries — I didn't have a reliable source for official French wording so I left that out rather than guess.

Test plan

  • csv.DictReader parses the file cleanly (809 rows, no errors).
  • Rebuilt the local sqlite DB from the CSVs and hit the live endpoints:
    • GET /api/v2/ability/as-one-glastrier/effect_entries now has an English entry.
    • GET /api/v2/ability/as-one-spectrier/ → same.
  • manage.py test pokemon_v2 passes (56 tests).

@FallenDeity

FallenDeity commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

follow the format of the csv, prose text should be single line instead of spanning multi line, also disclose AI usage since the pr desc in comparison to the problem its solving is looking a bit bulky/ai generated

@santichausis

Copy link
Copy Markdown
Contributor Author

Good call, fixed — I had concatenated the full effect text of Unnerve + Chilling Neigh/Grim Neigh across multiple paragraphs, which was overkill. Simplified both entries to a single line using the official in-game description instead ("This Ability combines the effects of both Calyrex's Unnerve Ability and Glastrier's/Spectrier's Chilling Neigh/Grim Neigh Ability").

Re: AI — yes, I used Claude as an assistant to move faster (research, drafting, running the test suite), but I reviewed and verified every change myself, including rebuilding the local DB and hitting the live endpoints to confirm the output before opening the PR. I didn't just hand this off and paste the result.

@jemarq04

jemarq04 commented Aug 1, 2026

Copy link
Copy Markdown
Member

Ability prose is often multiline, as can be seen with the very first ability. What it was set to before is perfectly fine, and is a bit clearer on the effects of the ability. Could you revert this recent commit and sync with the master branch? Thanks!

…ectrier

Both abilities had zero rows in ability_prose.csv, so effect_entries
was empty for them despite every other ability having at least an
English entry.

Fixes PokeAPI#1615
Use the official in-game description (both abilities combine Unnerve
with Chilling Neigh or Grim Neigh) instead of concatenating the full
effect text of each component ability across multiple paragraphs.
@santichausis
santichausis force-pushed the data/as-one-ability-effect-entries branch from 66b5d40 to be951eb Compare August 2, 2026 01:34
@santichausis

Copy link
Copy Markdown
Contributor Author

Reverted and rebased onto master, thanks!

@Naramsim

Naramsim commented Aug 2, 2026

Copy link
Copy Markdown
Member

Merging, thanks!

@Naramsim
Naramsim merged commit 6bbadca into PokeAPI:master Aug 2, 2026
20 checks passed
@pokeapi-machine-user

Copy link
Copy Markdown

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user

Copy link
Copy Markdown

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

as-one-glastrier and as-one-spectrier abilities missing effect_entries

5 participants