Skip to content

Normalize CSV identifiers to ASCII slugs #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LoicOuth wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Normalize CSV identifiers to ASCII slugs #1438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a75a2d0
Normalize CSV identifiers to ASCII slugs
LoicOuth Mar 12, 2026
2c29b29
Merge branch 'master' into fix/normalize-csv-identifiers
LoicOuth Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions data/v2/csv/items.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1619,7 +1619,7 @@ id,identifier,category_id,cost,fling_power,fling_effect_id
1669,tera-orb,20,0,,
1670,scarlet-book,20,0,,
1671,violet-book,20,0,,
1672,kofu’s-wallet,22,0,,
1672,kofus-wallet,22,0,,
Copy link
Member

@phalt phalt Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given these were all originally broken and not returning anything, I think it's okay to just update them?

FWIW - I feel like most people use the hypermedia links in API responses to access items, which uses IDs.

Copy link
Contributor

@jemarq04 jemarq04 Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I was pretty sure from the beginning that these PRs were both AI, but I figured I'd be thorough with the review since this was something that would benefit future contributions. Since we offer accessing the URLs with the identifiers (which is actually what I tend to use) I think it's best to make sure that the URLs are all accessible.

It's been frustrating that the past three PRs have been all AI, but I see you're updating AI guidelines so I hope things will be different moving forward.

1673,tiny-bamboo-shoot,24,375,,
1674,big-bamboo-shoot,24,1500,,
1675,scroll-of-darkness,21,0,,
Expand Down Expand Up @@ -1703,7 +1703,7 @@ id,identifier,category_id,cost,fling_power,fling_effect_id
1753,apple,53,130,,
1754,kiwi,53,180,,
1755,pineapple,53,250,,
1756,jalapeño,53,220,,
1756,jalapeno,53,220,,
1757,horseradish,53,410,,
1758,curry-powder,53,450,,
1759,wasabi,53,330,,
Expand Down Expand Up @@ -1988,13 +1988,13 @@ id,identifier,category_id,cost,fling_power,fling_effect_id
2043,smiling-vee-pick,55,1200,,
2044,blue-poke-ball-pick,55,200,,
2045,auspicious-armor,55,3000,,
2046,leader’s-crest,55,3000,,
2046,leaders-crest,55,3000,,
2047,pink-bottle,55,2000,,
2048,blue-bottle,55,2000,,
2049,yellow-bottle,55,2000,,
2050,steel-bottle-(r),55,1500,,
2051,steel-bottle-(y),55,1500,,
2052,steel-bottle-(b),55,1500,,
2050,steel-bottle-r,55,1500,,
2051,steel-bottle-y,55,1500,,
2052,steel-bottle-b,55,1500,,
2053,silver-bottle,55,20000,,
2054,barred-cup,55,800,,
2055,diamond-pattern-cup,55,800,,
Expand All @@ -2007,10 +2007,10 @@ id,identifier,category_id,cost,fling_power,fling_effect_id
2062,slowpoke-cup,55,2000,,
2063,silver-cup,55,20000,,
2064,exercise-ball,55,2000,,
2065,plaid-tablecloth-(y),55,3000,,
2066,plaid-tablecloth-(b),55,3000,,
2067,plaid-tablecloth-(r),55,3000,,
2068,b&w-grass-tablecloth,55,0,,
2065,plaid-tablecloth-y,55,3000,,
2066,plaid-tablecloth-b,55,3000,,
2067,plaid-tablecloth-r,55,3000,,
2068,bw-grass-tablecloth,55,0,,
2069,battle-tablecloth,55,4000,,
2070,monstrous-tablecloth,55,2000,,
2071,striped-tablecloth,55,1500,,
Expand Down
4 changes: 2 additions & 2 deletions data/v2/csv/locations.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ id,region_id,identifier
607,6,palais-lane
608,6,parfum-palace
609,6,kalos-route-7
610,6,rivière-walk
610,6,riviere-walk
611,6,cyllage-city
612,6,kalos-route-8
613,6,muraille-coast
Expand Down Expand Up @@ -635,7 +635,7 @@ id,region_id,identifier
651,6,winding-woods
652,6,pokemon-village
653,6,kalos-route-21
654,6,dernière-way
654,6,derniere-way
655,6,kalos-route-22
656,6,detourner-way
657,6,kalos-victory-road
Expand Down
8 changes: 4 additions & 4 deletions data/v2/csv/move_meta_categories.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ id,identifier
1,ailment
2,net-good-stats
3,heal
4,damage+ailment
4,damage-ailment
5,swagger
6,damage+lower
7,damage+raise
8,damage+heal
6,damage-lower
7,damage-raise
8,damage-heal
9,ohko
10,whole-field-effect
11,field-effect
Expand Down
Loading