feat: safe invocation rejection diagnostics - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the existing invocation_invalid verdict, exit 20, journal settlement and no-retry behavior. Add an optional versioned headless terminal line with fixed category/field constants only. No raw input, paths, dynamic property names, validator messages or schema text is emitted.
ADR-0038: ephemeral diagnostics are not durable evidence or recovery authority. Provider grammar, REPL display, protocol/store schema and execution permissions are unchanged. No live provider or production deployment.
Verification
Local environment caveat
Normal-disk local tests encountered filesystem journal commit waits (jbd2_log_wait_commit), causing two existing REPL test timeouts and host process timeouts. With a dedicated tmpfs temporary directory, the same code and unchanged timeouts passed the complete workspace and host suite. No journal/fsync safeguard was disabled. tmpfs is functional verification, not disk power-loss certification. All six required upstream CI checks must pass before merge.