ci: only publish from tags that are on main - #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fern's SDK regeneration pipeline force-pushes a moving tag (
fern-generation-base--fernapi--fern-python-sdk) that points at a synthetic commit which is not onmain. Because thepublishjob inci.ymlcurrently runs on any pushed tag, these internal tags have been triggering unintended package releases (see the recent releases published without any merge tomain).What
Adds a guard to the
publishjob so it only publishes when the pushed tag points at a commit that is an ancestor oforigin/main:fetch-depth: 0(full history, soorigin/mainis available)git merge-base --is-ancestor "$GITHUB_SHA" origin/maincheck whose output gates the remaining publish steps viaif:— for any tag not onmain(including thefern-generation-base--*tags) the publish steps are skipped and the job still succeedsNormal release tags cut from
mainare unaffected.We'd also recommend deleting the existing
fern-generation-base--*tag in this repo and reviewing the package versions it published. A Fern-side fix to stop pushing these tags entirely is in progress; this is a defense-in-depth guard on the repo side.