Add tests for nested mapped parameters #306
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLaurenson-Visionick
force-pushed
the
fix/278
branch
2 times, most recently
from
475084b to
1664af6
Compare
added 2 commits
January 16, 2026 11:28
- Add nested_map_keys.yaml: test YAML with nested struct and __map_ parameter - Add nested_map_test.yaml: test YAML for basic nested map parsing - Add test_parse_nested_map_keys: test that nested map YAMLs parse correctly - Add test_get_dynamic_mapped_parameter_nested: unit test for function output - Update setup.py to install new test files
The old implementation only returned the key names without the parent struct path prefix. This caused generated code to reference non-existent members like 'updated_params.entries' instead of 'updated_params.nested.entries'. Changes: - Rename old get_dynamic_mapped_parameter to get_dynamic_mapped_parameter_names - Create new get_dynamic_mapped_parameter that builds full paths including parent struct prefixes (e.g., 'nested.entries' instead of just 'entries') - Update get_dynamic_parameter_map to use the renamed function
NickLaurenson-Visionick
force-pushed
the
fix/278
branch
from
1664af6 to
7fef7cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR aim to fix #278.
As mention in the issue, the root caused came from
get_dynamic_mapped_parameter_names, not return the full nested path:if the the field to be mapped was
.nested_field.final_field, the function returnfinal_fieldcausing error in the generated code.Regarding the test, I wrote some basic one, let me know if need to do something else