Skip to content

convert jacobian into RPY space #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
suchkristenwow wants to merge 1 commit into
base: humble
Choose a base branch
from
Draft

convert jacobian into RPY space #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions fuse_models/include/fuse_models/omnidirectional_3d_predict.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,9 +493,16 @@ inline void predict(fuse_core::Vector3d const& position1, Eigen::Quaterniond con
vel_linear2.y(), vel_linear2.z(), vel_angular2.x(), vel_angular2.y(), vel_angular2.z(), acc_linear2.x(),
acc_linear2.y(), acc_linear2.z(), jacobians.data(), jacobian_quat2rpy);

// TODO(henrygerardmoore): figure out how to fix this
// see https://github.com/locusrobotics/fuse/pull/354#discussion_r1884288806
jacobian << J[0], J[1], J[2], J[3], J[4].block<15, 2>(0, 0);
// Convert J[1] from quaternion space (15x4) to RPY space (15x3) using the
// pseudo-inverse of the quaternion-to-RPY Jacobian.
// Chain rule: J[1] = d(state2)/d(quat1) = d(state2)/d(rpy1) * d(rpy)/d(quat)
// So: d(state2)/d(rpy1) = J[1] * pinv(d(rpy)/d(quat))
Eigen::Map<fuse_core::Matrix<double, 3, 4>> j_quat2rpy_map(jacobian_quat2rpy);
fuse_core::Matrix<double, 4, 3> j_quat2rpy_pinv =
j_quat2rpy_map.transpose() * (j_quat2rpy_map * j_quat2rpy_map.transpose()).inverse();
fuse_core::Matrix<double, 15, 3> J1_rpy = J[1] * j_quat2rpy_pinv;

jacobian << J[0], J1_rpy, J[2], J[3], J[4];
Comment on lines +496 to +505
Copy link
Copy Markdown
Collaborator

@henrygerardmoore henrygerardmoore Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM broadly; do we need to add a case to cover the singular cases where pitch is +/ 90 degrees? I'd think that would mean the jacobian_quat2rpy would be undefined maybe, so it should perhaps be handled above


// Convert back to quaternion
orientation2 = Eigen::AngleAxisd(rpy[2], Eigen::Vector3d::UnitZ()) *
Expand Down