Refactor LaserPositionUpdate as LaserDrawExt and further optimize it - #2336
Draft
DeathFishAtEase wants to merge 14 commits into
Draft
Refactor LaserPositionUpdate as LaserDrawExt and further optimize it#2336DeathFishAtEase wants to merge 14 commits into
DeathFishAtEase wants to merge 14 commits into
Conversation
Pure relocation - the implementation is copied verbatim from src/Misc/Hooks.LaserDraw.cpp, which keeps only the laser drawing and Z-adjust hooks.
… a LaserDrawExt O(1) extension LaserPositionUpdate looked up tracking data in a std::unordered_map on every frame for every LaserDrawClass. The tracking data now lives in a LaserDrawExt extension whose pointer is stored split across the two unused 16-bit padding words of LaserDrawClass (align_22 @ 0x22, align_4A @ 0x4A), giving O(1) access on the hot path. The extension follows the project Ext conventions (Body.h/cpp, ExtContainer/ExtMap, TypeRegistry registration).
…LaserPositionUpdate
DeathFishAtEase
added
❓Phobos bug
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Coronia
reviewed
Aug 11, 2026
| #include <Helpers/Macro.h> | ||
| #include <Utilities/Patch.h> | ||
|
|
||
| static void NukeTrackingHooks() |
Contributor
There was a problem hiding this comment.
put this in Phobos::ApplyOptimizations() like all the other hook nuking functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo: