Unit image changes in various theater types - #2322
Conversation
|
To Chinese users:
|
NetsuNegi
left a comment
There was a problem hiding this comment.
You don't need to use Nullable in this PR for now
| Nullable<UnitTypeClass*> Image_Urban; | ||
| Nullable<UnitTypeClass*> Image_Desert; | ||
| Nullable<UnitTypeClass*> Image_NewUrban; | ||
| Nullable<UnitTypeClass*> Image_Lunar; |
There was a problem hiding this comment.
| Nullable<UnitTypeClass*> Image_Lunar; | |
| Valueable<UnitTypeClass*> Image_Lunar; |
| Nullable<UnitTypeClass*> Image_Snow; | ||
| Nullable<UnitTypeClass*> Image_Urban; | ||
| Nullable<UnitTypeClass*> Image_Desert; | ||
| Nullable<UnitTypeClass*> Image_NewUrban; |
There was a problem hiding this comment.
| Nullable<UnitTypeClass*> Image_NewUrban; | |
| Valueable<UnitTypeClass*> Image_NewUrban; |
| Nullable<UnitTypeClass*> Image_Temperate; | ||
| Nullable<UnitTypeClass*> Image_Snow; | ||
| Nullable<UnitTypeClass*> Image_Urban; | ||
| Nullable<UnitTypeClass*> Image_Desert; |
There was a problem hiding this comment.
| Nullable<UnitTypeClass*> Image_Desert; | |
| Valueable<UnitTypeClass*> Image_Desert; |
|
|
||
| Nullable<UnitTypeClass*> Image_Temperate; | ||
| Nullable<UnitTypeClass*> Image_Snow; | ||
| Nullable<UnitTypeClass*> Image_Urban; |
There was a problem hiding this comment.
| Nullable<UnitTypeClass*> Image_Urban; | |
| Valueable<UnitTypeClass*> Image_Urban; |
| Valueable<int> BurstPerTurret; | ||
|
|
||
| Nullable<UnitTypeClass*> Image_Temperate; | ||
| Nullable<UnitTypeClass*> Image_Snow; |
There was a problem hiding this comment.
| Nullable<UnitTypeClass*> Image_Snow; | |
| Valueable<UnitTypeClass*> Image_Snow; |
| std::vector<CoordStruct> ExtraTurretOffsets; | ||
| Valueable<int> BurstPerTurret; | ||
|
|
||
| Nullable<UnitTypeClass*> Image_Temperate; |
There was a problem hiding this comment.
| Nullable<UnitTypeClass*> Image_Temperate; | |
| Valueable<UnitTypeClass*> Image_Temperate; |
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
There was a problem hiding this comment.
Excluding aircraft seems unreasonable.
For vehicles, Ares has already dealt with the SHP. You only need to handle the voxel. The reading approach should align with the Ares pattern.
https://ares-developers.github.io/Ares-docs/new/alternatetheaterart.html
There are also issues with the implementation approach. The Theater does not switch mid‑game, so modifications should be made during asset loading to load different assets. This is different from damaged images. Damaged images and original images are used within the same game session, so loading both simultaneously is reasonable.
Unit image changes in various theater types
In
rulesmd.ini: