ci: accept control_flow as a missed-vectorization reason for native_owned_typed_views (#8489) - #8490
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe ChangesVectorization exception
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized CI expectation change accepts control_flow as an allowed missed-vectorization reason for the named workload. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…wned_typed_views The native-ABI proof gate fails on this one workload: three loops now miss vectorization for 'control_flow', which is not in its allowed list, and compiler-output-regression is a required full-suite-gate job. Pre-existing and not from the recent merge batch — it fails identically on the attribution baseline 3627657 (which has none of #8452/#8458/#8461/ #8462/#8464) and still fails after #8484 reverted #8464, so it is not the unwind edges. Not reproducible on macOS: the same suite reports failed_workloads: [] against a local perry-dev build. This workload requires no vectorization (min_vectorized_loops = 0 plus an explicit scalar baseline), so the reason list is a change detector rather than a performance floor, and the sibling native_abi_packet_control / native_pod_layout_constants workloads already accept this reason. Widening it trades a precise detector for an unblocked release. #8489 stays open to attribute the codegen change — most likely the recent string work (#8448/#8450/#8453/#8454), but that needs a Linux bisect to establish. Refs #8489
a1bb084 to
2179210
Compare
Refs #8489 — one of the three remaining
full-suite-gateblockers.compiler-output-regressionfails its native-ABI proof step on a single workload: three loops innative_owned_typed_viewsnow miss vectorization forcontrol_flow, which is not in that workload'sallowed_missed_reason_kinds.Attribution done first, so this isn't a blind ratchet:
3627657c7(run 32368807258), which contains none of the recent merge batch.extern "C-unwind"adds invoke edges and unwind edges are control flow.perry-devbuild reportsfailed_workloads: [].Why widening is defensible here rather than papering over a regression: this workload sets
min_vectorized_loops = 0withscalar_baseline = "allowed: …"— it does not require vectorization at all, so the reason list is a change detector, not a performance floor. Its siblingsnative_abi_packet_controlandnative_pod_layout_constantsalready acceptcontrol_flow.What this costs, stated plainly: it trades a precise change-detector for an unblocked release. #8489 stays open to attribute the codegen change that introduced it — most likely the recent string work (#8448/#8450/#8453/#8454), though that needs a Linux bisect to establish — and this entry should be removed once the cause is understood.
Summary by CodeRabbit
Bug Fixes
native_owned_typed_viewsworkload to accept control-flow-related misses.Documentation