[PER-10476] [1] Add missing properties and create fallbacks to enable migration from navigateLean to getWithChildren by aasandei-vsp · Pull Request #996 · PermanentOrg/web-app

aasandei-vsp · 2026-04-21T13:13:40Z

Issue: PER-10476
Subtask: https://permanent.atlassian.net/browse/PER-10677

The tests are only to make sure we didn't make any regressions, as it does not bring any new functionality.

Manual test cases

Setup: log in on an archive that has folders with images, records with metadata, and at least one unlisted share link.
EXPECTED: private/public navigation is unaffected by this PR (still uses navigateLean) — only the flows below need testing.

Unlisted share link — folder

Open an unlisted share link to a folder in an incognito window.
- EXPECTED: The folder contents load correctly.
Navigate into a subfolder, then go back up using the breadcrumbs.
- EXPECTED: Breadcrumb labels are correct and each breadcrumb link navigates to the right folder.
Open the same share link while logged in.
- EXPECTED: The folder contents load correctly.

Unlisted share link — error handling

Open an invalid or revoked unlisted share link.
- EXPECTED: A graceful error message is shown — no blank page, no errors in the console.

Sidebar — record

Select a record and wait for the sidebar to finish loading.
- EXPECTED: Full metadata is shown (dates, description, tags, location).
Click the Share button.
- EXPECTED: The button is enabled and the sharing dialog opens.

Sidebar — folder

Select a folder and wait for the sidebar to finish loading.
- EXPECTED: Full metadata is shown and the Share button is enabled.

Record and folder edits (v2 endpoints)

Edit a record's date/time via the edit modal.
- EXPECTED: The value saves and redisplays correctly after the sidebar refreshes.
Edit a folder's date.
- EXPECTED: The value saves and redisplays correctly.

Record and folder shared with me

EXPECTED: The shared workspace has the top buttons disabled(Delete, Copy, Share...)

Select a record that has been shared with me as viewer
- EXPECTED: The sidebar metadata is not editable
Select a folder that has been shared with me and navigate through it
- EXPECTED: All folders and files inside it have the same accessRole as the parent.

codecov · 2026-04-21T13:15:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.39%. Comparing base (8c2bb85) to head (a366ced).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
+ Coverage   52.26%   52.39%   +0.13%     
==========================================
  Files         354      354              
  Lines       12093    12105      +12     
  Branches     2186     2189       +3     
==========================================
+ Hits         6320     6343      +23     
+ Misses       5550     5536      -14     
- Partials      223      226       +3

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

slifty · 2026-07-27T19:43:48Z

@aasandei-vsp I'm back in action and coming back to review things!

I'm finding this PR / commit hard to review as written. Would you be able to take a stab at updating the commit message + PR title / description to make it clear what the purpose of these changes are?

I think it's basically Migrate record lookup to use stela, right? Or maybe it's just a partial implementation of that overall epic?

aasandei-vsp · 2026-07-28T11:01:40Z

@aasandei-vsp I'm back in action and coming back to review things!

I'm finding this PR / commit hard to review as written. Would you be able to take a stab at updating the commit message + PR title / description to make it clear what the purpose of these changes are?

I think it's basically Migrate record lookup to use stela, right? Or maybe it's just a partial implementation of that overall epic?

@slifty That makes perfect sense! Because I was deep into this story, I forgot that other people need to understand the context :)))

Together with @cecilia-donnelly , we have decided that making smaller PRs if possible, for the ease of review would be better, so that's why the big story of migrating to getWithChildren has been split across multiple subtasks.

I've updated the commit message and the description.
TL;DR Basically there were some properties missing from the stela record and folder that were stopping the full migration to getWithChildren. After @liam-lloyd added them on BE, I've also made the mapping on the FE.

Hope this helps, otherwise I can definitely provide more details.

Copilot

Pull request overview

Groundwork for migrating folder navigation from legacy v1 endpoints (/folder/navigateLean / /folder/navigateMin) to the Stela-backed getWithChildren by expanding Stela→VO field mapping, adding a legacy folderId fallback, and aligning success/error shapes with existing v1 consumers.

Changes:

Expanded Stela→FolderVO mapping (archive/link IDs, breadcrumb path arrays, created/updated timestamps) and added an item-level accessRole default.
Added resolveFolderId fallback via legacy /folder/get, then fetches folder + children in parallel.
Added/updated unit tests for the new mapping, fallback behavior, and v1-shaped error handling.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
`src/app/shared/services/api/record.repo.ts`	Sets a default `accessRole` during Stela→`RecordVO` conversion to preserve existing UI permission gates.
`src/app/shared/services/api/folder.repo.ts`	Extends Stela folder shape + mapping, adds folderId resolution fallback, and wraps errors into a v1-like `FolderResponse`.
`src/app/shared/services/api/folder.repo.spec.ts`	Adds tests covering error shaping, folderId resolution fallback, and newly-mapped fields used by breadcrumbs/metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+		// accessRole is intentionally always owner: the backend removed item-level accessRole
+		// because all non-owner values were deprecated in 2020. Real access is on ShareVOs.
+		accessRole: 'access.role.owner',


Added accessRole, archiveNumber, folderLinkId, parentFolder.parentFolderLinkId, createdAt, updatedAt, paths.folderLinkIds, paths.archiveNumbers in StelaFolder and StelaRecord so navigateLean and navigateMin can be fully replaced by getWithChildren. Created fallback for missing folderId, call folder and children in parallel for optimization and convert v2 call failure to v1 unsuccessful response. Issue: PER-10476

aasandei-vsp · 2026-08-04T13:08:23Z

@slifty I am pausing the work on this to pick up some more urgent tasks. I will let you know when it's ready for review again. Thank you!

aasandei-vsp self-assigned this Apr 21, 2026

aasandei-vsp marked this pull request as draft April 21, 2026 13:13

aasandei-vsp changed the title ~~[WIP] [PER-10476] Replace navigateLean with getWithChildren~~ [WIP] [PER-10476] [BLOCKED BY BE] Replace navigateLean with getWithChildren Jun 4, 2026

aasandei-vsp force-pushed the PER-10476-replace-navigate-lean branch from b65fcfb to bb0a021 Compare July 8, 2026 13:30

aasandei-vsp force-pushed the PER-10476-replace-navigate-lean branch from bb0a021 to e54b14f Compare July 16, 2026 08:56

aasandei-vsp changed the title ~~[WIP] [PER-10476] [BLOCKED BY BE] Replace navigateLean with getWithChildren~~ [PER-10476] Extend Stela conversion in getWithChildren and record mapping Jul 16, 2026

aasandei-vsp requested review from cecilia-donnelly and slifty July 16, 2026 09:08

aasandei-vsp marked this pull request as ready for review July 16, 2026 09:08

aasandei-vsp mentioned this pull request Jul 16, 2026

[PER-10476] [2] Migrate navigation consumers to getWithChildren #1089

Draft

aasandei-vsp changed the title ~~[PER-10476] Extend Stela conversion in getWithChildren and record mapping~~ [PER-10476] [1] Extend Stela conversion in getWithChildren and record mapping Jul 23, 2026

aasandei-vsp force-pushed the PER-10476-replace-navigate-lean branch 2 times, most recently from 45f656e to 01c70e9 Compare July 28, 2026 10:55

aasandei-vsp changed the title ~~[PER-10476] [1] Extend Stela conversion in getWithChildren and record mapping~~ [PER-10476] [1] Extend getWithChildren toward replacing navigateLean/navigateMin (Stela migration groundwork) Jul 28, 2026

slifty requested a review from Copilot July 28, 2026 20:23

Copilot started reviewing on behalf of slifty July 28, 2026 20:24 View session

Copilot AI reviewed Jul 28, 2026

View reviewed changes

aasandei-vsp force-pushed the PER-10476-replace-navigate-lean branch from 01c70e9 to 65dc646 Compare August 4, 2026 08:44

aasandei-vsp changed the title ~~[PER-10476] [1] Extend getWithChildren toward replacing navigateLean/navigateMin (Stela migration groundwork)~~ [PER-10476] [1] Add missing properties to enable migration from navigateLean to getWithChildren Aug 4, 2026

aasandei-vsp changed the title ~~[PER-10476] [1] Add missing properties to enable migration from navigateLean to getWithChildren~~ [PER-10476] [1] Add missing properties and create fallbacks to enable migration from navigateLean to getWithChildren Aug 4, 2026

aasandei-vsp force-pushed the PER-10476-replace-navigate-lean branch from 65dc646 to b13e8fb Compare August 4, 2026 09:36

aasandei-vsp force-pushed the PER-10476-replace-navigate-lean branch from b13e8fb to a366ced Compare August 4, 2026 09:51

Navigation Menu

Uh oh!

[PER-10476] [1] Add missing properties and create fallbacks to enable migration from navigateLean to getWithChildren - #996

[PER-10476] [1] Add missing properties and create fallbacks to enable migration from navigateLean to getWithChildren#996
aasandei-vsp wants to merge 1 commit into
mainfrom
PER-10476-replace-navigate-lean

aasandei-vsp commented Apr 21, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

slifty commented Jul 27, 2026 •

edited

Loading

Uh oh!

aasandei-vsp commented Jul 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aasandei-vsp commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

aasandei-vsp commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

The tests are only to make sure we didn't make any regressions, as it does not bring any new functionality.

Manual test cases

Unlisted share link — folder

Unlisted share link — error handling

Sidebar — record

Sidebar — folder

Record and folder edits (v2 endpoints)

Record and folder shared with me

Uh oh!

codecov Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

slifty commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aasandei-vsp commented Jul 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aasandei-vsp commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aasandei-vsp commented Apr 21, 2026 •

edited

Loading

codecov Bot commented Apr 21, 2026 •

edited

Loading

slifty commented Jul 27, 2026 •

edited

Loading