Make Plugin dsl keyword App-specific #1764
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugins were caching a single DSL instance at import time. In a multi‑app process, that meant `plugin->dsl` and bare dsl calls resolved to the DSL of the first app that loaded the plugin, breaking per‑app behavior. This change makes the plugin `dsl` accessor resolve dynamically on each call by walking the call stack to find the consuming app's DSL, and explicitly skips plugin packages to avoid recursion. This preserves compatibility with bare `dsl` usage while restoring correct per‑app resolution. This approach keeps the existing API (including bareword `dsl`) as is.
Member
Author
|
Also fixes #1630. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins were caching a single DSL instance at import time. In a multi‑app process, that meant
plugin->dsland bare dsl calls resolved to the DSL of the first app that loaded the plugin, breaking per‑app behavior.This change makes the plugin
dslaccessor resolve dynamically on each call by walking the call stack to find the consuming app's DSL, and explicitly skips plugin packages to avoid recursion. This preserves compatibility with baredslusage while restoring correct per‑app resolution.This approach keeps the existing API (including bareword
dsl) as is.