fix: New Issue modal unusable on mobile#519
Open
oaquique wants to merge 1 commit intoPeppermint-Lab:mainfrom
Open
fix: New Issue modal unusable on mobile#519oaquique wants to merge 1 commit intoPeppermint-Lab:mainfrom
oaquique wants to merge 1 commit intoPeppermint-Lab:mainfrom
Conversation
Move CreateTicketModal out of the sidebar component tree into the layout so it is not unmounted when the mobile Sheet closes. Bump the Dialog z-index above the Sheet overlay and auto-close the sidebar when the modal is triggered.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #488 — On mobile (Android/iOS), clicking "New Issue" from the sidebar menu opens the modal behind the sidebar overlay, and closing the sidebar also unmounts the modal.
Root cause:
CreateTicketModalwas rendered insideSidebarContent, which on mobile lives inside aSheetcomponent. Two problems resulted:z-50while the Dialog usedz-10, so the modal appeared behind the overlayFix:
CreateTicketModalfromAppSidebarto theShadLayout, outside the sidebar DOM tree but still insideSidebarProvideropen-create-ticket) to communicate between the sidebar's keyboard handler and the modalz-10toz-[60](above the Sheet'sz-50)setOpenMobile(false)Test plan