-
Notifications
You must be signed in to change notification settings - Fork 60
Vector: allowDropAnywhere = true for roundingFunctions menu
#162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
waait theres a semicolon |
|
will need to check if this affects already existing blocks |
|
Pretty sure it wouldn't excluding extenuating circumstances such as someone having directly modified their project JSON. |
|
i need to check if changing a menu from no reporter to yes reporter breaks previous projects that use that block |
|
oops I already said that |
yeah but aren't no accept menu values stored differently to yes accept menu |
indeed, as accept reports is |
|
sooo merging this would be bad |
nooooooooo |
its going to break ALL the projects... |
|
what if.... we make a NEW block and menu instead of updating the existing one.... |
|
i mean yeah thats.... kinda exactly what should be done 🥱 |
|
i used my Magical Powers™ to cast a Magical Spell™ to do allathat |
|
mmgghhh i mean at this point couldn't you just put a switch statement in a custom block and let that do rounding menu thing |
allowDropAnywhere = falseis EVIL!!!! make ittrue!will just return the vector unmodified if invalid rounding method is chosen or whatevs
maybe works