Skip to content

Conversation

@NotEmbin
Copy link

allowDropAnywhere = false is EVIL!!!! make it true!

will just return the vector unmodified if invalid rounding method is chosen or whatevs

maybe works :trollface:

@NotEmbin
Copy link
Author

waait theres a semicolon

@jwklong
Copy link
Member

jwklong commented Oct 16, 2025

will need to check if this affects already existing blocks

@Steve0Greatness
Copy link

Pretty sure it wouldn't excluding extenuating circumstances such as someone having directly modified their project JSON.

@jwklong
Copy link
Member

jwklong commented Nov 8, 2025

i need to check if changing a menu from no reporter to yes reporter breaks previous projects that use that block

@jwklong
Copy link
Member

jwklong commented Nov 8, 2025

oops I already said that

@jwklong
Copy link
Member

jwklong commented Nov 8, 2025

Pretty sure it wouldn't excluding extenuating circumstances such as someone having directly modified their project JSON.

yeah but aren't no accept menu values stored differently to yes accept menu

@RedMan13
Copy link

RedMan13 commented Nov 8, 2025

yeah but aren't no accept menu values stored differently to yes accept menu

indeed, as accept reports is input>shadow>field and none accepting is just field
and also the serializer simply doesnt know any better than what the save says is true, so it will inevitably cause old projects to have those menus be empty and unusable

@jwklong
Copy link
Member

jwklong commented Nov 8, 2025

sooo merging this would be bad

@NotEmbin
Copy link
Author

NotEmbin commented Nov 8, 2025

sooo merging this would be bad

nooooooooo

@jwklong
Copy link
Member

jwklong commented Nov 8, 2025

nooooooooo

its going to break ALL the projects...

@NotEmbin
Copy link
Author

NotEmbin commented Nov 8, 2025

what if.... we make a NEW block and menu instead of updating the existing one....

@RedMan13
Copy link

RedMan13 commented Nov 8, 2025

i mean yeah thats.... kinda exactly what should be done 🥱

@NotEmbin
Copy link
Author

NotEmbin commented Nov 8, 2025

i used my Magical Powers™ to cast a Magical Spell™ to do allathat

@jwklong
Copy link
Member

jwklong commented Nov 8, 2025

mmgghhh i mean at this point couldn't you just put a switch statement in a custom block and let that do rounding menu thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants