-
Notifications
You must be signed in to change notification settings - Fork 21
Standardize error handling with specific exit codes #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @dlebauer |
Alomir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for cleaning up the code! (One minor suggestion to change)
Co-authored-by: Mike Longfritz <Mike.Longfritz@gmail.com>
|
Hi @Alomir , |
|
Also, the sipnet.out files should not be deleted |
Alomir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the change to .gitignore in #253; please remove that file from this PR, and you'll be good to go!
|
@ayushman - you didn't remove |
Description:
Error handling uses inconsistent patterns:
exit(1)(generic)exit(EXIT_CODE_*)(specific error codes)Location: At various places in the codebase
Example from
modelParams.c:Changes
Standardize on using specific exit codes with error messages: