v4 #8
Open
v4 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misraX
reviewed
Nov 24, 2021
| private $base_url; | ||
|
|
||
| function __construct($secret_key=null) | ||
| function __construct($secret_key=null,$api_version=null,$base_url=null) |
Contributor
There was a problem hiding this comment.
base_url should have "https://flashapi.paymob.com/" as a default.
misraX
reviewed
Nov 24, 2021
| //return: str api_next_url | ||
| $api_next_url = "http://127.0.0.1:8000/api/next"; | ||
| return $api_next_url; | ||
| $api_next_url = $base_url."/api/next"; |
Contributor
There was a problem hiding this comment.
No need to use that anymore, remove it.
misraX
reviewed
Nov 24, 2021
| $delivery_needed=False,); | ||
| $base_url="http://127.0.0.1:8000"; | ||
| $api_version="v1"; | ||
| $app=new Paymob($secret_key,$base_url,$$api_version); |
Contributor
There was a problem hiding this comment.
Neither the base_url nor the api_version should be mandate.
misraX
reviewed
Nov 24, 2021
| "state"=> "Utah", | ||
| ], | ||
| $delivery_needed=False,); | ||
| echo $app->intent->create('',$secret_key,$body); |
Contributor
There was a problem hiding this comment.
Why do we send the secret_key again ????
Contributor
There was a problem hiding this comment.
It's optional we don't need to send it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.