-
Notifications
You must be signed in to change notification settings - Fork 0
feat: improve token counting and add brevity pattern #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PatrickRuddiman
wants to merge
3
commits into
main
Choose a base branch
from
l6macz-codex/check-context-length-before-request
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
6d30bf4
feat: improve token counting and add brevity pattern
PatrickRuddiman d9d3c57
refactor: enhance summarization instructions for clarity and effectiv…
PatrickRuddiman fbdd16e
fix: correct typos and improve clarity in commit message guidelines
PatrickRuddiman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| using TiktokenSharp; | ||
|
|
||
| namespace WriteCommit.Services; | ||
|
|
||
| public static class TokenHelper | ||
| { | ||
| private static readonly Dictionary<string, TikToken> Encoders = new(); | ||
|
|
||
| public static int EstimateTokens(string text, string model) | ||
| { | ||
| try | ||
| { | ||
| if (!Encoders.TryGetValue(model, out var encoder)) | ||
| { | ||
| encoder = TikToken.EncodingForModel(model); | ||
| Encoders[model] = encoder; | ||
| } | ||
| return encoder.Encode(text).Count; | ||
| } | ||
| catch | ||
| { | ||
| // Fallback heuristic | ||
| return Math.Max(1, text.Length / 4); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # IDENTITY and PURPOSE | ||
| You are a summarizer machine. Your job is to take a list of chunk objects (from the chunk_git_diff pattern) and distill them into a minimal, high-level summary that preserves the intent and spirit of the changes, so that an AI can write a relevant, human-like git commit message. | ||
|
|
||
| Think step by step: | ||
| 1. Read all chunk objects. | ||
| 2. Identify the main themes, features, or fixes represented. | ||
| 3. Merge related or repetitive changes into a single, concise statement. | ||
| 4. Omit low-level details, but keep enough context for a meaningful commit message. | ||
|
|
||
| # OUTPUT SECTIONS | ||
| - TITLE: A short, imperative summary of the overall change (max 1 line) | ||
| - DESCRIPTION: 1-3 sentences elaborating on the main changes, grouped by theme or feature | ||
| - TAGS: comma-separated list of key topics, features, or subsystems touched | ||
|
|
||
| # OUTPUT | ||
| - Output only the above sections, no extra commentary or formatting. | ||
| - Do not include chunk IDs, file lists, or raw diffs. | ||
| - Focus on clarity, intent, and relevance for a commit message. | ||
|
|
||
| # INPUT: | ||
| INPUT: | ||
|
|
||
| <chunk objects from chunk_git_diff> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since systemPrompt remains unchanged throughout the method, consider caching its token estimate once rather than repeatedly recalculating it to improve maintainability.