Skip to content

[pob2-port] Fix crash on hovering over legacy shared items #9901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: dev
Choose a base branch
from
+37 −0
Open

[pob2-port] Fix crash on hovering over legacy shared items #9901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions spec/System/TestItemMods_spec.lua.rej
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
diff a/spec/System/TestItemMods_spec.lua b/spec/System/TestItemMods_spec.lua (rejected hunks)
@@ -33,6 +33,20 @@ describe("TetsItemMods", function()
assert.are.equals(2, legacyLines)
end)

+ it("shows a fallback tooltip when an item's base is no longer supported", function()
+ local item = new("Item", [[
+ Rarity: Unique
+ Legacy Item
+ Removed Base
+ ]])
+ local tooltip = new("Tooltip")
+
+ assert.has_no.errors(function()
+ build.itemsTab:AddItemTooltip(tooltip, item)
+ end)
+ assert.is_truthy(tooltip.lines[#tooltip.lines].text:find("Item base is not supported", 1, true))
+ end)
+
it("aggregates matching ring item rarity lines before applying ring bonus effect", function()
build.configTab.input.customMods = "30% increased bonuses gained from left Equipped Ring"
build.configTab:BuildModList()
15 changes: 15 additions & 0 deletions src/Classes/ItemsTab.lua.rej
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
diff a/src/Classes/ItemsTab.lua b/src/Classes/ItemsTab.lua (rejected hunks)
@@ -3232,6 +3232,13 @@ function ItemsTabClass:AddItemTooltip(tooltip, item, slot, dbMode, maxWidth)
tooltip.tooltipHeader = item.rarity
tooltip.center = true
tooltip.color = rarityCode
+ -- Shared items can use old base names that no longer exist. Add a tooltip so they can be copied or removed without causing a crash.
+ if not item.base or not item.baseName then
+ tooltip:AddLine(fontSizeTitle, rarityCode..(item.title or item.name or "Unknown Item"), "FONTIN SC")
+ tooltip:AddSeparator(30)
+ tooltip:AddLine(fontSizeTitle, colorCodes.NEGATIVE.."Item base is not supported by the current version.", "FONTIN SC")
+ return
+ end
-- Item name
if item.title then
tooltip:AddLine(fontSizeTitle, rarityCode..item.title, "FONTIN SC")