Fix stat comparison for radius jewels (timeless, Thread of Hope, etc.)#9746
Draft
mcagnion wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Draft
Fix stat comparison for radius jewels (timeless, Thread of Hope, etc.)#9746mcagnion wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
mcagnion wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
mcagnion
force-pushed
the
feature/radius-jewel-stat-diff
branch
3 times, most recently
from
6770c61 to
372c10f
Compare
- Fix stat diff tooltip for removing equipped radius jewels: use jewelRadiusIndex instead of hardcoded radius, revert conquered nodes via removeNodes/addNodes override with hashOverrides support - Fix stat diff for removing Thread of Hope / Impossible Escape: remove nodes only reachable through the jewel and their transitive dependents - Add 9 tests covering radius jewel stat comparison Ported onto upstream PathOfBuildingCommunity#9744 sort-based compareSlot loop: override logic now lives inside getReplacedItemAndOutput() instead of the old inline for loop. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mcagnion
force-pushed
the
feature/radius-jewel-stat-diff
branch
from
372c10f to
a090a49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The stat diff tooltip when removing equipped radius jewels (Timeless, Thread of Hope, Impossible Escape) was missing or incomplete:
Steps taken to verify a working solution:
spec/System/TestRadiusJewelStatDiff_spec.lua):Screenshots:
Timeless jewel (Lethal Pride) — before:
Timeless jewel (Lethal Pride) — after:
Impossible Escape — before:
Impossible Escape — after:
Thread of Hope — before:
Thread of Hope — after:
🤖 Generated with Claude Code