Add masteries to power report#9604
Open
ksnyder9801 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Add masteries to power report#9604ksnyder9801 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
ksnyder9801 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
ksnyder9801
commented
Mar 17, 2026
| for nodeId, node in pairs(self.build.spec.nodes) do | ||
| wipeTable(node.power) | ||
| if node.type == "Mastery" then | ||
| node.power.masteryEffects = { } |
Author
There was a problem hiding this comment.
NB: adding a new table to node.power since a single power per node can't represent unallocated mastery options
| end | ||
| end | ||
| end | ||
|
|
Author
There was a problem hiding this comment.
opted to duplicate the power calc in the loop here instead of a bigger refactor for readability
Member
There was a problem hiding this comment.
I'd prefer to not duplicate this logic, actually.
Wires77
requested changes
Apr 15, 2026
Member
Wires77
left a comment
Wires77
left a comment
There was a problem hiding this comment.
There is some opportunity to combine things here, but I like the idea, and love the added test
Comment on lines
+1108
to
+1127
| local nodePower = (effectPower.singleStat or 0) * ((displayStat.pc or displayStat.mod) and 100 or 1) | ||
| local pathPower = ((effectPower.pathPower or effectPower.singleStat or 0) / pathDist) * ((displayStat.pc or displayStat.mod) and 100 or 1) | ||
| local nodePowerStr = s_format("%"..displayStat.fmt, nodePower) | ||
| local pathPowerStr = s_format("%"..displayStat.fmt, pathPower) | ||
|
|
||
| nodePowerStr = formatNumSep(nodePowerStr) | ||
| pathPowerStr = formatNumSep(pathPowerStr) | ||
|
|
||
| if (nodePower > 0 and not displayStat.lowerIsBetter) or (nodePower < 0 and displayStat.lowerIsBetter) then | ||
| nodePowerStr = colorCodes.POSITIVE .. nodePowerStr | ||
| elseif (nodePower < 0 and not displayStat.lowerIsBetter) or (nodePower > 0 and displayStat.lowerIsBetter) then | ||
| nodePowerStr = colorCodes.NEGATIVE .. nodePowerStr | ||
| end | ||
| if (pathPower > 0 and not displayStat.lowerIsBetter) or (pathPower < 0 and displayStat.lowerIsBetter) then | ||
| pathPowerStr = colorCodes.POSITIVE .. pathPowerStr | ||
| elseif (pathPower < 0 and not displayStat.lowerIsBetter) or (pathPower > 0 and displayStat.lowerIsBetter) then | ||
| pathPowerStr = colorCodes.NEGATIVE .. pathPowerStr | ||
| end | ||
|
|
||
| local effectLabelParts = isAlloc and not node.allMasteryOptions and node.sd or effect.stats or effect.sd |
Member
There was a problem hiding this comment.
This is all the same code as the section above, I think we can combine these sections. At least have a function that they share.
| end | ||
| end | ||
| end | ||
|
|
Member
There was a problem hiding this comment.
I'd prefer to not duplicate this logic, actually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3704 .
Description of the problem being solved:
Masteries are not in the power report
Steps taken to verify a working solution:
Link to a build that showcases this PR:
literally any build
Before screenshot:
After screenshot: