Skip to content

Conversation

@Peechey
Copy link
Contributor

@Peechey Peechey commented Nov 23, 2025

Fixes #9348

Description of the problem being solved:

We are loading Shared Items before LoadTree is called, so data.jewelRadius isn't set yet. I'm moving the ChangeUserPath a few lines down under LoadTree in Main. Alternatively, we could move LoadTree up a few lines above where ChangeUserPath was, or we could check if data.jewelRadius is set in Item.ParseRaw and if not, run the function. A few ways to do it.

Steps taken to verify a working solution:

  • Throw any radius jewel into shared and reload, verify crash vs success
  • Have a radius jewel in shared items, close and reopen PoB

After screenshot:

sharedItemsGood

@Peechey Peechey added the crash Causes PoB to crash and is High Priority label Nov 23, 2025
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to what I was thinking, though I just pulled LoadSharedItems out of ChangeUserPath and put it below LoadTree

@Wires77 Wires77 merged commit f5d1d72 into PathOfBuildingCommunity:dev Nov 23, 2025
3 checks passed
@Peechey Peechey deleted the fix/shared-items-crash branch November 23, 2025 22:07
@LocalIdentity LocalIdentity added the pob2 Label for features that should be ported over to PoB-PoE2 label Dec 15, 2025
github-actions bot pushed a commit to PathOfBuildingCommunity/PathOfBuilding-PoE2 that referenced this pull request Dec 15, 2025
LocalIdentity pushed a commit to PathOfBuildingCommunity/PathOfBuilding-PoE2 that referenced this pull request Dec 15, 2025
* Apply changes from PathOfBuildingCommunity/PathOfBuilding#9349

* Fix conflict

---------

Co-authored-by: Peechey <Peechey@users.noreply.github.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crash Causes PoB to crash and is High Priority pob2 Label for features that should be ported over to PoB-PoE2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Application Crashes on Loading Shared Items

3 participants